Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptography requirement too strong? #177

Closed
jneves opened this issue Feb 26, 2017 · 2 comments · Fixed by #179
Closed

Cryptography requirement too strong? #177

jneves opened this issue Feb 26, 2017 · 2 comments · Fixed by #179

Comments

@jneves
Copy link
Contributor

jneves commented Feb 26, 2017

I have 2 packages that are requiring cryptography, one with a restriction of >=1.7.1 and current pyxero master at ==1.3.1. This fails. As I was using pyxero with 1.7.1 before, I'd like to ask if the restriction has a reason other than making sure the package is there. If not, I can submit a patch for cryptography>=1.3.1.

@romgar
Copy link
Collaborator

romgar commented Feb 27, 2017

I'm +1 for this change, as I had the exact same issue in one of my projects.

@aidanlister, any reason to have an explicit version pinned? I saw 35f32d8 referring #90 and #91 related to this pinning.

@aidanlister
Copy link
Collaborator

That's right, I pinned it to resolve module import bugs that were popping up. I'm happy to remove it now, I'm sure the issue has been resolved in the other package.

romgar added a commit that referenced this issue Mar 9, 2017
Allow for more recent versions of cryptography. Closes #177
jneves added a commit to wegotpop/pyxero that referenced this issue Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants