net/tcp: discard connect reference before free

connect reference should be set to 0 before free Signed-off-by: chao.an <anchao@xiaomi.com>
freakishness · Jul 2, 2022 · b88a1fd · b88a1fd
1 parent bd713d6
commit b88a1fd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/net/tcp/tcp_close.c b/net/tcp/tcp_close.c
@@ -58,6 +58,10 @@ static void tcp_close_work(FAR void *param)
   /* Stop the network monitor for all sockets */
 
   tcp_stop_monitor(conn, TCP_CLOSE);
+
+  /* Discard our reference to the connection */
+
+  conn->crefs = 0;
   tcp_free(conn);
 
   net_unlock();
@@ -356,7 +360,6 @@ int tcp_close(FAR struct socket *psock)
   /* Perform the disconnection now */
 
   tcp_unlisten(conn); /* No longer accepting connections */
-  conn->crefs = 0;    /* Discard our reference to the connection */
 
   /* Break any current connections and close the socket */
 

diff --git a/net/tcp/tcp_conn.c b/net/tcp/tcp_conn.c
@@ -696,6 +696,7 @@ FAR struct tcp_conn_s *tcp_alloc(uint8_t domain)
            * waiting for it.
            */
 
+          conn->crefs = 0;
           tcp_free(conn);
 
           /* Now there is guaranteed to be one free connection.  Get it! */