fix(write): Add EOL at the end of translations files

freakzlike · Jun 25, 2023 · 924fb9e · 924fb9e
1 parent d3d10e4
commit 924fb9e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -37,7 +37,7 @@
     "lint": "eslint src/ tests/ --ext .ts --ignore-path .gitignore",
     "lint:fix": "pnpm run lint --fix",
     "demo:cli": "node bin/cli.cjs examples/namespaces/i18n-extract.config.cjs",
-    "release": "semantic-release --dry-run"
+    "release": "semantic-release"
   },
   "dependencies": {
     "glob": "^10.2.6"

diff --git a/src/write.ts b/src/write.ts
@@ -7,13 +7,14 @@ export const writeTranslations = async (
 ): Promise<void> => {
   await Promise.all(Object.values(translationResults).map(async (languageTranslations) => {
     await Promise.all(Object.values(languageTranslations).map(async ({ filePath, translations }) => {
+      const content = JSON.stringify(translations, undefined, 2)
 
       const directory = dirname(filePath)
       if (!existsSync(directory)) {
         mkdirSync(directory, { recursive: true })
       }
 
-      writeFileSync(filePath, JSON.stringify(translations, undefined, 2))
+      writeFileSync(filePath, `${content}\n`)
     }))
   }))
 }
diff --git a/tests/extract.spec.ts b/tests/extract.spec.ts
@@ -15,7 +15,7 @@ beforeEach(() => {
   mockedMkdir.mockReset().mockReturnValue(undefined)
 })
 
-const toJSON = (v: unknown) => JSON.stringify(v, undefined, 2)
+const toJSON = (v: unknown) => `${JSON.stringify(v, undefined, 2)}\n`
 
 /**
  * i18nExtract