Document a bit more about query parameters #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No actual guide changes, just moved the language more towards a SHOULD/MUST kind of style, tweaked some examples, and adjusted some white-space.
pbrisbin
commented
Sep 16, 2021
| - Good: `{attribute}={value1},{value2},{value3},...` | ||
| - Bad: `{attribute}={value}` | ||
|
|
||
| This is because: |
There was a problem hiding this comment.
I didn't think this justification was super valuable, so once I mentioned the "behave like [in]" in the new section, I figured we could drop all this. If anyon disagrees, I can move this content up there instead.
eborden
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits.