Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed result to report all missing mandatory args #7

Merged

Conversation

itayporezky
Copy link
Contributor

Under Results struct, Mandatory would append only the first missing argument and return:

return results, fmt.Errorf("mandatory argument '%s' not found: %w", name, ErrMandatoryArgument)

This pull request will make it so Results.Mandatory would include the full list of missing arguments
Also added a unit test for validation.

Copy link

codecov bot commented Mar 15, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@fred1268 fred1268 merged commit ff1c811 into fred1268:development Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants