Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check unnecessary copies of data structures #101

Closed
pmelchior opened this issue Jun 24, 2019 · 2 comments
Closed

Check unnecessary copies of data structures #101

pmelchior opened this issue Jun 24, 2019 · 2 comments

Comments

@pmelchior
Copy link
Owner

We have many places where we copy sed, psfs, morphologies etc. Given the high memory demand of the code and the performance target, let's make sure we don't waste time on unnecessary copies.

@fred3m
Copy link
Collaborator

fred3m commented Jun 24, 2019

Never mind my comment in the PR, you are right. If we want my intended functionality we need to pass copy=False to the array wrappers.

@pmelchior
Copy link
Owner Author

#147 addresses this issue in multiple ways:

  • sources are in boxes
  • parameters are generated by source models without any copying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants