Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: breaking changes #8

Merged
merged 2 commits into from
Nov 28, 2023
Merged

refact: breaking changes #8

merged 2 commits into from
Nov 28, 2023

Conversation

fredbi
Copy link
Owner

@fredbi fredbi commented Nov 28, 2023

  • refactored packages: middlewares and exporters now at the top level
  • added unit tests for the log and tracer packages
  • fixed a few issues with propagating fields in traces
  • added more options to expose the full set of zap settings
  • removed import of the datadog package

* added unit tests for the log and tracer packages
* fixed a few issues with propagating fields in traces
* added more options to expose the full set of zap settings

Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7022125579

  • 39 of 72 (54.17%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+41.7%) to 56.868%

Changes Missing Coverage Covered Lines Changed/Added Lines %
log/factory.go 3 13 23.08%
log/logger_options.go 5 28 17.86%
Totals Coverage Status
Change from base Build 7003772055: 41.7%
Covered Lines: 207
Relevant Lines: 364

💛 - Coveralls

@fredbi fredbi merged commit 55ee689 into master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants