New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vega support #153
Vega support #153
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 69.28% 68.23% -1.06%
==========================================
Files 17 17
Lines 661 617 -44
==========================================
- Hits 458 421 -37
+ Misses 203 196 -7
Continue to review full report at Codecov.
|
Travis is failing on mac due to an issue with the Cairo build - I need to dig into this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is fantastic and in really good shape!! Only one comment, and then we can merge this :)
That unfortunately happens regularly... It is really frustrating, the whole BinDeps.jl binary provider story that Cairo.jl utilizes is just not reliable and seems to break a lot... I think the only proper solution is that someone creates a BinaryBuilder.jl style solution for Cairo.jl and Rsvg.jl. But that implies Gtk.jl also needs to be ported, and at that point it is a mega project... In any case, that failure is clearly not related to your PR, so I think we can merge things here independently of the Cairo.jl situation. |
@davidanthoff that's good to know about Cairo... (kind of - it's always nicer when things just work). I've gitignored the project.toml and when this is merged I'll do another PR with just the Project.toml and the updated travis script so it can be merged whenever attobot is ready. On the IJulia side, I've updated that PR to preemptively include the mime types for vega v5 and vegalite v3 so we should be able to switch those over whenever they're supported by jupyter. |
Super, thanks a lot! |
This PR proposes a few changes to increase support for Vega specifications:
AbstractVegaSpec
type to simplify some mostly duplicate functionsI noticed the examples folder seems to use an outdated syntax - can that be removed as well?
This PR shouldn't be merged until the corresponding IJulia PR is merged so they are ready to support the v4 mime type.
I expect this will need to be updated shortly as Vega recently released v5.