Use TableTraits.jl for tabular data sources #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fredo-dedup Have you thought about this? I would very much like to move all of this code out of IterableTables and into the respective packages, plus it would make VegaLite work with way, way more new data sources. Folks could directly do things like |
|
I think I missed or forgot about this PR, sorry about that. |
acheryauka
pushed a commit
to acheryauka/VegaLite.jl
that referenced
this pull request
Jan 4, 2022
Add support for CUDA 3 and skip CUDA tests when not functional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the iterable tables integration from IterableTables.jl into this package here. With that, any of the iterable tables source types can be piped into a vegalite graph. I also removed the special
DataFrameandDataTablecases because those are also covered by the iterable tables interface.I include a dependency on
IterableTablesfor now, but eventually we will be able to remove that (essentially once the iterable tables integration for things like DataFrames and DataTables has been moved into those packages).This stuff is julia 0.6 only, not sure whether that is a problem...
Oh, and things will only work with
masterfrom IterableTables.jl. If you are ok with this PR here, I'll tag a version of IterableTables and then you can merge things here.