Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue running creosote in a large workspace #128

Closed
fredrikaverpil opened this issue Mar 10, 2023 · 6 comments
Closed

Issue running creosote in a large workspace #128

fredrikaverpil opened this issue Mar 10, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@fredrikaverpil
Copy link
Owner

fredrikaverpil commented Mar 10, 2023

Picking up on the discussion here #114 (comment) in this issue.

ping @sanmai-NL

@fredrikaverpil
Copy link
Owner Author

fredrikaverpil commented Mar 10, 2023

Hi again @sanmai-NL so I've released a new version of creosote where you can use the --verbose argument to get more output. Would you mind doing that and send me the log?

First, maybe we can try with just the core folder, in case we can figure out what false positives you might see there?

@fredrikaverpil fredrikaverpil self-assigned this Mar 10, 2023
@fredrikaverpil fredrikaverpil added the bug Something isn't working label Mar 10, 2023
@fredrikaverpil
Copy link
Owner Author

fredrikaverpil commented Mar 10, 2023

@sanmai-NL quite a few fixes has been done today, so please try using the latest version from the main branch and provide the full log output of creosote (--verbose) if you are still experiencing issues.

$ pipx install --suffix=@main --force git+https://github.com/fredrikaverpil/creosote.git@main
$ creosote@main --venv .venv ...
$ pipx uninstall creosote@main

@sanmai-NL
Copy link
Contributor

sanmai-NL commented Mar 15, 2023

Thanks.

I did the following.

.pyproject.toml:

[tool.pdm.dev-dependencies]
dev = [
    "creosote @ git+https://github.com/fredrikaverpil/creosote.git#main",
]
creosote --venv .venv --verbose --paths azure core datapipeline_ff

That works for me. Can you please document that consecutive --paths parameters override the previous?

Single --paths: an unused dependency is one that isn't referenced at least once in all the Python source code under the specified paths. Multiple --paths: an unused dependency is one that isn't referenced at least once in each of the subsets of source code under each specified path.

@fredrikaverpil
Copy link
Owner Author

fredrikaverpil commented Mar 15, 2023

Thanks. How can I make sure that --paths.

I'm not sure if there was a question in there...? 😄

That works for me.

Do you mean you can finally scan your workspace/project? 🤞😅
Btw, I'm about to release a new version where I fix #145

@fredrikaverpil
Copy link
Owner Author

fredrikaverpil commented Mar 15, 2023

Can you please document that consecutive --paths parameters override the previous?

Hm, this was actually not my intent. I wanted to check for your source code (a set of python files/folders) whether it wasn't anymore using the dependencies you've specified in your pyproject.toml/requirements.txt.

I'll look into this, treating this as a separate bug. 😢

@fredrikaverpil
Copy link
Owner Author

@sanmai-NL I understand that you made creosote work in your large workspace and I’m therefore closing this issue. We can reopen this if misinterpreted you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants