Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creosote does not exit with expected status when unused deps are found #145

Closed
sanmai-NL opened this issue Mar 15, 2023 · 2 comments · Fixed by #146
Closed

Creosote does not exit with expected status when unused deps are found #145

sanmai-NL opened this issue Mar 15, 2023 · 2 comments · Fixed by #146
Labels
bug Something isn't working

Comments

@sanmai-NL
Copy link
Contributor

What happened?

It is customary for tools like Creosote to exit with a failure-signalling exit status (value other than zero) when an issue is found. Creosote doesn't. The effect is that CI/CD pipelines in principle cannot detect unused dependencies with Creosote.

Reproduction steps

$ creosote --paths azure/ core/ datapipeline_ff/
Found packages in pyproject.toml: nsone, pip, pulumi, pulumi-azure-native, pulumi-command, pulumi-kubernetes, pulumi-ns1, setuptools
Oh no, bloated venv! 🤢 🪣
Unused packages found: nsone, pip, setuptools
$ echo $status
0

Relevant log output

2.3.7 (current main branch revision)
@sanmai-NL sanmai-NL added the bug Something isn't working label Mar 15, 2023
@fredrikaverpil
Copy link
Owner

fredrikaverpil commented Mar 15, 2023

This sounds really strange. I was sure it already did this. I'll have a look later today.

@fredrikaverpil
Copy link
Owner

Thanks for reporting @sanmai-NL 👍
This was a pretty bad one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants