add splice edge case

fredrikwidlund · Oct 26, 2019 · d65d9b7 · d65d9b7
1 parent 82a8585
commit d65d9b7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/dynamic/list.c b/src/dynamic/list.c
@@ -107,6 +107,9 @@ void list_splice(void *object1, void *object2)
 {
   list_item *to, *from;
 
+  if (object1 == object2)
+    return;
+
   to = list_object_item(object1);
   from = list_object_item(object2);
 

diff --git a/test/list.c b/test/list.c
@@ -140,13 +140,26 @@ void unit()
   list_destruct(&l, NULL);
 }
 
+void edge()
+{
+  list l1;
+  int *i;
+
+  list_construct(&l1);
+
+  i = list_push_back(&l1, (int[]){1}, sizeof (int));
+  list_splice(i, i);
+  list_destruct(&l1, NULL);
+}
+
 int main()
 {
   const struct CMUnitTest tests[] = {
     cmocka_unit_test(core),
     cmocka_unit_test(object_release),
     cmocka_unit_test(alloc),
-    cmocka_unit_test(unit)
+    cmocka_unit_test(unit),
+    cmocka_unit_test(edge)
   };
 
   return cmocka_run_group_tests(tests, NULL, NULL);