Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

Widget not restored to correct location after throwing VetoDragException #33

Closed
GoogleCodeExporter opened this issue Mar 13, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

I'm using GWT 1.4.61-leopard, gwt-dnd-2.0.7.jar.

FlowPanelDropController, with a PickupDragController and no drag proxy, 
dragging a widget to the 
same FlowPanel that it started in.

If you throw a VetoDragException from a FlowPanelDropController the widgets are 
restored to the 
wrong location, because PickupDragController#dragEnd() is restoring the widgets 
via 
#restoreSelectedWidgetsLocation() before calling  #onLeave().

The fix seems to be to call onLeave() first, to remove the positioner, then 
call the 
restoreSelectedWigetsLocation().  I've attached a patch.

Original issue reported on code.google.com by dunhamst...@gmail.com on 26 Apr 2008 at 8:57

Attachments:

@GoogleCodeExporter
Copy link
Author

Thank you for the bug report and the patch!

I ended up with a different fix (committed in r715) than the one you proposed, 
which
I believe addresses the underlying cause.

Original comment by fredsa on 29 Apr 2008 at 3:58

  • Changed state: Fixed
  • Added labels: OpSys-All

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant