Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #60 #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Issue #60 #61

wants to merge 1 commit into from

Conversation

sgparry
Copy link

@sgparry sgparry commented Jun 6, 2018

No description provided.

@Chris2011
Copy link

If our PRs will not merge, I suggest you to fork it, what you already did and make a new version.

@Chris2011
Copy link

Offtopic: Maybe you can provide PRs to this plugin: https://gitlab.com/mcheung63/netbeans-antlr because it is more active.

@sgparry
Copy link
Author

sgparry commented Jun 11, 2018

Peter Cheung's plugin is good, but lacks the ANT build support that this plugin has. I do not think that a ANT build task has to be as complex as this one though. Why does it need to fully parse the actual ANTLR files?
If FYV does not reply in a few weeks, I will create new repo - a straight fork is not enough because the history as-is is contaminated with lots of CRLFs and is fragmented with different folders for each version of the plugin. This defeats the purpose of Git. My repo will have all FYV's commits but applied to single folder and with corrected line-endings. I will also update to share one code base between multiple NB versions too - currently you have to make same the change three times. It will take a lot of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants