Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifier search doesn't find all function occurrences #5

Closed
lategoodbye opened this issue Feb 22, 2017 · 3 comments
Closed

Identifier search doesn't find all function occurrences #5

lategoodbye opened this issue Feb 22, 2017 · 3 comments

Comments

@lategoodbye
Copy link

If i try to search the function msleep via identifier search, i get in Elixir only 4 hits instead of 1627 hits in the old version.
@pokazef
Copy link
Contributor

pokazef commented Feb 23, 2017

For the moment, idententifiers are filtered with ad-hoc syntactic rules to prevent many keywords from being wrongly identified (see isIdent() in lib.py).

I'll loosen the rules and regenerate a database shortly.

pokazef added a commit that referenced this issue Feb 27, 2017
@pokazef
Merge branch 'ident-rules'
e4a84c8 
Improves #5

With these matching rules, lowercase-only idents of length 6 or more
are recognized. To prevent a blow-up in the indexation time caused by
idents such as "struct", "static" and "define", a black list of
reserved (or obviously local) keywords has been added.
@pokazef
Copy link
Contributor

pokazef commented Feb 27, 2017

After commit e4a84c8, "msleep" and "jiffies" are matched but other lowercase-only identifiers shorter than 6 chars aren't, yet.

@lategoodbye
Copy link
Author

Thanks

@elfring elfring mentioned this issue Apr 11, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lategoodbye @pokazef