Replace 5 with $quality - Else quality is always 5

[jenstornell]

It should probably be $quality instead of 5.

function convert($from, $to, $quality = -1) {
  $converter = new ImageConverter();
  return $converter->convert($from, $to, 5);
}

[peter279k]

It's not weird.

• According to the imagejpeg function reference, the default image quality value is -1.
• According to the imagepng function reference, the default image quality value is -1.
• The imagegif and imagebmp functions don't have the quality value.

Could you explain more details about why you think this default quality is weird?

[jenstornell]

@peter279k I was in a hurry when adding this issue. It's not the built in PHP default value that is weird, it's my convert function default value that is weird, or wrong is a better word.

When sending a $quality value to it, it will be ignored, because it's never sent to the class method. It will always end up as 5.

I just need to move the $quality argument and replace 5 with it and it should be fine.

[peter279k]

@jenstornell, thank you for your explanation.

I know that and I think we have to consider/note that some image formats in PHP GD extension will not have the quality argument.

[peter279k]

And the function you create should change into following code snippets:

function convert($from, $to, $quality = -1) {
  $converter = new ImageConverter();
  return $converter->convert($from, $to, $quality);
}

[jenstornell]

@peter279k Yes. I tested sending a quality argument to a method that did not support it and it will just be ignored, so I think it will be fine out of the box. I think a note about it in the docs will do (maybe that's what you ment?). Also the quality argument differ between formats. Some have 1-100 and others 1-9 etc. Docs would be good not forcing users to go to php.net.

Yes, I know how the function will look like. I did not have the time to implement it yesterday, that's why I added an issue instead.

[peter279k]

@jenstornell, thank you for your comment.

Perhaps we should have the quality validation before passing the $quality to specific image manipulation functions?

[jenstornell]

✔️