Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update token fill frequency #95

Merged
merged 2 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/trTCM.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ typedef struct {

u64 tokenRate;
u64 lastUpdate;
u64 refillTokenTime;

spinlock_t lock;
} TrafficPolicer;
Expand Down
20 changes: 16 additions & 4 deletions src/gtpu/trTCM.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,33 @@ TrafficPolicer* newTrafficPolicer(u64 tokenRate) {

p->lastUpdate = ktime_get_ns();

p->refillTokenTime = 0;

return p;
}

Color policePacket(TrafficPolicer* p, int pktLen) {
u64 tokensToAdd;
u64 tc, te;
u64 elapsed;
u64 tokensToAdd = 0;
u64 tc, te = 0;
u64 elapsed = 0;
u64 now = ktime_get_ns();

spin_lock(&p->lock);

elapsed = now - p->lastUpdate;
p->lastUpdate = now;

tokensToAdd = elapsed * p->tokenRate / 1000000000;
// the total time elapsed since the last token refill
p->refillTokenTime = p->refillTokenTime + elapsed;

// use 8000000ns because the minimum token rate is 1 Kbit/s (125 bytes/s)
if (p->refillTokenTime >= 8000000) {
// add at least one token
p->refillTokenTime = p->refillTokenTime - 8000000;
tokensToAdd = p->tokenRate / 125;
Copy link
Collaborator

@tim-ywliu tim-ywliu Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#define REFILL_TOKEN_INTERVAL 1000000 // ns (=1ms), 1 token = 1 byte
#define SECOND_TO_NANOSECOND 1000000000

if (p->refillTokenTime >= REFILL_TOKEN_INTERVAL) {
        // add at least one token
        p->refillTokenTime = p->refillTokenTime - REFILL_TOKEN_INTERVAL;
        tokensToAdd = p->tokenRate * (REFILL_TOKEN_INTERVAL  / SECOND_TO_NANOSECOND); 

} else {
tokensToAdd = 0;
}

tc = p->tc + tokensToAdd;
te = p->te;
Expand Down