refactor: App, Server, Processor, Consumer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HanHongChen
commented
May 8, 2024
•
HanHongChen
commented
- consumer
- amf_service.go
- nrf_service.go
- udr_service.go
- consumer.go
- make
- service
- copy server side code
- implement server structure & refactor sbi_{SVC}.go
- Add GetCertPemPath() & GetCertKeyPath()
- Remove Legacy Code
- RegisterNFInstance()
- Processor
- processor/processor.go
- change producer to processor
- tear down response and request
- run free5gc
…refactor/sbi-logic
andy89923
changed the title
HanHongChen
force-pushed
the
refactor/sbi-logic
branch
from
6351765
to
c4ec427
Compare
|
Is this PR ready for review? |
andy89923
reviewed
Jun 4, 2024
| @@ -1,3 +1,4 @@ | |||
| /bin/ | |||
There was a problem hiding this comment.
accidentally added
Comment on lines
+119
to
+129
| s.router.Use(cors.New(cors.Config{ | ||
| AllowMethods: []string{"GET", "POST", "OPTIONS", "PUT", "PATCH", "DELETE"}, | ||
| AllowHeaders: []string{ | ||
| "Origin", "Content-Length", "Content-Type", "User-Agent", | ||
| "Referrer", "Host", "Token", "X-Requested-With", | ||
| }, | ||
| ExposeHeaders: []string{"Content-Length"}, | ||
| AllowCredentials: true, | ||
| AllowAllOrigins: true, | ||
| MaxAge: CorsConfigMaxAge, | ||
| })) |
Comment on lines
+28
to
+30
| const ( | ||
| CorsConfigMaxAge = 86400 | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.