This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Fixed: UPF leaks PfcpXact if PFCP Session Report Response is not processed #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essed - Activate timerResponse of local PfcpXact - Remove unused code from `PfcpXactRemoteCreate()`
ianchen0119
reviewed
Dec 6, 2021
| @@ -444,6 +442,10 @@ Status PfcpXactUpdateRx(PfcpXact *xact, uint8_t type) { | |||
| "local " : "remote", xact->step, type, | |||
| GetIP(&xact->gnode->sock->remoteAddr), | |||
| GetPort(&xact->gnode->sock->remoteAddr)); | |||
|
|
|||
There was a problem hiding this comment.
You moved TimerStop into PFCP_XACT_FINAL_STAGE of case PFCP_LOCAL_ORIGINATOR.
In this case,
If the pfcp xact belongs PFCP_REMOTE_ORIGINATOR, I suppose its timer won't be stopped correctly.
If my assumption is wrong, please let me know.
Tks!
There was a problem hiding this comment.
Sorry for late reply.
xact->timerResponse exists only when xact->origin is PFCP_LOCAL_ORIGINATOR but does not exist when PFCP_REMOTE_ORIGINATOR.
TimerStop() should be moved here, because otherwise xact->timerResponse will be stopped right after it is started.
Thanks,
|
Hi @shugo-h Thank you! |
free5gc-org
approved these changes
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PfcpXactRemoteCreate()This PR is regarding with Issue#289.