webconsole refactoring with react 18 #47

kishiguro · 2023-07-30T15:17:15Z

webconsole refactoring with react 18 and typescript and material ui.

brianchennn · 2023-07-31T07:52:11Z

I can't login. Can you fix it?

ianchen0119 · 2023-08-01T09:06:21Z

frontend/WebUI-diff/WebUI.diff

@@ -0,0 +1,234 @@
+diff --color -rc webconsole-orig/backend/WebUI/api_webui.go webconsole/backend/WebUI/api_webui.go


Hi @kishiguro
Do we need this patch file after PR merged?

@ianchen0119 No, no need of merging the patch. it is included in the PR.

@ianchen0119 diff has been removed to avoid confusion.

brianchennn · 2023-08-01T11:20:56Z

@kishiguro
I think the UI is beautiful, but there's an error when testing with UERANSIM.

UE's setting:

kishiguro · 2023-08-01T11:28:58Z

@brianchennn are you able to login with User: free5gc Pass: admin ?

brianchennn · 2023-08-01T11:29:33Z

@brianchennn are you able to login with User: free5gc Pass: admin ?

Yes, I can login now. User: admin. Password: free5gc

brianchennn · 2023-08-01T11:33:31Z

There are some issues:

How can I create 100 UEs simultaneously ?
When I add Flow Rules, error happened.
It isn't able to display the UEs information created by old webconsole.

kishiguro · 2023-08-01T11:33:50Z

@brianchennn

Yes, I can login now.

nice!

I think the UI is beautiful, but there's an error when test with UERANSIM.

Let me double check with the same configuration

brianchennn · 2023-08-01T11:35:52Z

@kishiguro
Panic when adding Flow Rules and register to free5gc by UERANSIM:

2023-08-01T11:34:35.547912779Z [INFO][SMF][Consumer] SendNFDiscoveryServingAMF ok
2023-08-01T11:34:35.548042234Z [INFO][SMF][CTX] Allocated UE IP address: 10.60.0.6
2023-08-01T11:34:35.548063530Z [INFO][SMF][CTX] Selected UPF: UPF
2023-08-01T11:34:35.548080809Z [INFO][SMF][PduSess][pdu_session_id:1][supi:imsi-208930000000997] Allocated PDUAdress[10.60.0.6]
2023-08-01T11:34:35.548279120Z [INFO][NRF][DISC] Handle NFDiscoveryRequest
2023-08-01T11:34:35.550266626Z [INFO][NRF][GIN] | 200 |       127.0.0.1 | GET     | /nnrf-disc/v1/nf-instances?preferred-locality=area1&requester-nf-type=SMF&target-nf-type=PCF |
2023-08-01T11:34:35.551690950Z [INFO][PCF][SMpolicy] Handle CreateSmPolicy
2023-08-01T11:34:35.555088331Z [INFO][UDR][DataRepo] Handle PolicyDataUesUeIdSmDataGet
2023-08-01T11:34:35.556130071Z [INFO][UDR][GIN] | 200 |       127.0.0.1 | GET     | /nudr-dr/v1/policy-data/ues/imsi-208930000000997/sm-data?dnn=internet&snssai=%7B%22sst%22%3A1%2C%22sd%22%3A%22010203%22%7D |
2023-08-01T11:34:35.557666677Z [ERRO][PCF][GIN] panic: interface conversion: interface {} is nil, not float64
goroutine 653 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/free5gc/util/logger.ginRecover.func1.1()
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:284 +0x1a5
panic({0xbf8fc0, 0xc0006177a0})
        /usr/local/go/src/runtime/panic.go:1038 +0x215
github.com/free5gc/pcf/internal/sbi/producer.createSMPolicyProcedure({0x0, 0x0, {0x0, 0x0}, {0xc0005d20c0, 0x14}, {0x0, 0x0, 0x0}, 0x1, ...})
        /home/brian/free5gc-github/NFs/pcf/internal/sbi/producer/smpolicy.go:226 +0x2c45
github.com/free5gc/pcf/internal/sbi/producer.HandleCreateSmPolicyRequest(0xc000371b60)
        /home/brian/free5gc-github/NFs/pcf/internal/sbi/producer/smpolicy.go:37 +0x145
github.com/free5gc/pcf/internal/sbi/smpolicy.HTTPSmPoliciesPost(0xc000362700)
        /home/brian/free5gc-github/NFs/pcf/internal/sbi/smpolicy/api_default.go:56 +0x29a
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/free5gc/util/logger.ginRecover.func1(0xc000362700)
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:316 +0x7b
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/free5gc/util/logger.ginToLogrus.func1(0xc000362700)
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:251 +0x82
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc000242340, 0xc000362700)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/gin.go:620 +0x671
github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc000242340, {0xe8e318, 0xc000534028}, 0xc000362600)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/gin.go:576 +0x1dd
golang.org/x/net/http2.(*serverConn).runHandler(0x13ea320, 0x0, 0x0, 0xc0003faf00)
        /home/brian/go/pkg/mod/golang.org/x/net@v0.7.0/http2/server.go:2311 +0x8c
created by golang.org/x/net/http2.(*serverConn).processHeaders
        /home/brian/go/pkg/mod/golang.org/x/net@v0.7.0/http2/server.go:2025 +0x5f4
2023-08-01T11:34:35.557825062Z [INFO][PCF][GIN] | 500 |       127.0.0.1 | POST    | /npcf-smpolicycontrol/v1/sm-policies |
2023-08-01T11:34:35.558279343Z [ERRO][SMF][GIN] panic: interface conversion: interface {} is nil, not models.ProblemDetails
goroutine 338 [running]:
runtime/debug.Stack()
        /usr/local/go/src/runtime/debug/stack.go:24 +0x65
github.com/free5gc/util/logger.ginRecover.func1.1()
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:284 +0x1a5
panic({0xaad1a0, 0xc0000e3380})
        /usr/local/go/src/runtime/panic.go:1038 +0x215
github.com/free5gc/smf/internal/sbi/producer.HandlePDUSessionSMContextCreate({0xc00059c480, {0xc0006fec00, 0x12, 0x3e8}})
        /home/brian/free5gc-github/NFs/smf/internal/sbi/producer/pdu_session.go:169 +0x16fd
github.com/free5gc/smf/internal/sbi/pdusession.HTTPPostSmContexts(0xc0006d0700)
        /home/brian/free5gc-github/NFs/smf/internal/sbi/pdusession/api_sm_contexts_collection.go:54 +0x265
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/free5gc/util/logger.ginRecover.func1(0xc0006d0700)
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:316 +0x7b
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/free5gc/util/logger.ginToLogrus.func1(0xc0006d0700)
        /home/brian/go/pkg/mod/github.com/free5gc/util@v1.0.5-0.20230511064842-2e120956883b/logger/logger.go:251 +0x82
github.com/gin-gonic/gin.(*Context).Next(...)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/context.go:174
github.com/gin-gonic/gin.(*Engine).handleHTTPRequest(0xc0000836c0, 0xc0006d0700)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/gin.go:620 +0x671
github.com/gin-gonic/gin.(*Engine).ServeHTTP(0xc0000836c0, {0xc99d28, 0xc00052c1b0}, 0xc0006d0600)
        /home/brian/go/pkg/mod/github.com/gin-gonic/gin@v1.9.0/gin.go:576 +0x1dd
golang.org/x/net/http2.(*serverConn).runHandler(0xc000524930, 0xc0005757d0, 0x8a24a6, 0xc0004d9080)
        /home/brian/go/pkg/mod/golang.org/x/net@v0.7.0/http2/server.go:2311 +0x8c
created by golang.org/x/net/http2.(*serverConn).processHeaders
        /home/brian/go/pkg/mod/golang.org/x/net@v0.7.0/http2/server.go:2025 +0x5f4
2023-08-01T11:34:35.558543765Z [INFO][SMF][GIN] | 500 |       127.0.0.1 | POST    | /nsmf-pdusession/v1/sm-contexts |
2023-08-01T11:34:35.558940606Z [ERRO][AMF][Gmm][amf_ue_ngap_id:RU:8,AU:8(3GPP)][supi:SUPI:imsi-208930000000997] CreateSmContextRequest Error: undefined response type

brianchennn · 2023-08-01T11:39:10Z

@kishiguro
After editing Flow Rules, these fields still empty except IP Filter which I set 'none':

brianchennn · 2023-08-01T11:43:56Z

@kishiguro
I want to let you know that another contributor is also modifying the webconsole in PR #43. Free5gc team will choose better one to merge.

kishiguro · 2023-08-01T13:09:39Z

@brianchennn just fixed a issue of admin tenant handling. now it should show subscription which created before.

kishiguro · 2023-08-01T13:20:52Z

@brianchennn Seems there is a bug of setting flow rules. Let me fix it.

kishiguro · 2023-08-01T21:05:25Z

@brianchennn FlowRule (and QosFlows) handling has been fixed. Would you mind to try again?

brianchennn · 2023-08-02T08:00:33Z

@kishiguro
Thanks for fixing the bug. Now I can't add second DNN:
https://youtu.be/Rj9iRkLBZ6A

kishiguro · 2023-08-02T12:26:40Z

@brianchennn

@kishiguro Thanks for fixing the bug. Now I can't add second DNN: https://youtu.be/Rj9iRkLBZ6A

Thanks for pointing out. Just fixed the issue. Would you mind to check it out?

brianchennn · 2023-08-03T06:31:27Z

@kishiguro
That's great!
Next, can you help me to add this field for adding multiple UEs by increment SUPI? Sometimes we may do that for testing. Thanks a lot !

kishiguro · 2023-08-03T06:37:05Z

@brianchennn

Next, can you help me to add this field for adding multiple UEs by increment SUPI? Sometimes we may do that for testing.

sure, wait a sec.

kishiguro · 2023-08-03T07:48:30Z

@brianchennn just added support for multiple UEs by increment SUPI. would you mind to try?

brianchennn · 2023-08-04T06:17:14Z

@kishiguro It works well !
Now, could you make the default S-NSSAI setting be 2 S-NSSAI Configuragtions as below?

kishiguro · 2023-08-04T10:03:49Z

@brianchennn

Now, could you make the default S-NSSAI setting be 2 S-NSSAI Configuragtions as below?

Now default S-NSSAI configuartion will be set. Would you mind to double check?

brianchennn · 2023-08-05T05:19:26Z

@kishiguro
Could you add the confirm password field when creating/modifying user of tenant?
And the password field should be concealed in browser view.
I just added these features in PR #44.

I also found that when creating a tenant, the hint of this field is Tenant ID, but it should be Tenant Name. Tenant ID is random generated as UUID.

kishiguro · 2023-08-05T17:40:38Z

@brianchennn got it let me integrate the confirm password feature.

kishiguro · 2023-08-07T16:01:58Z

@brianchennn I have integrated Password Confirmation feature. "Tenant ID" is also fixed as "Tenant Name".

brianchennn · 2023-08-08T08:10:10Z

@tim-ywliu
I think we can merge this PR.

kishiguro added 10 commits June 26, 2023 03:45

Apply changes for react-18.

661a8be

Apply patches for react-18.

98fee90

Update favicon.

287622b

Fix SubscriberCreate error when no S-NSSAI is defined.

402484b

Show proper error message.

c4d6dc9

Add webconsole to .gitignore.

0ca5b46

Add MSISDN field in Subscription.

5b7149e

Make label to be consistent.

4ffecad

Update diff to 3.3.0.

0b50d0e

Merge branch 'main' into react-18

a677871

kishiguro mentioned this pull request Jul 30, 2023

Update/ rewrite webconsole to recent dependency versions #35

Closed

add apiConfig as default value

4b3fc5b

ianchen0119 reviewed Aug 1, 2023

View reviewed changes

Fix bug of identify admin tenant.

c191a14

Fix FlowRule handling.

dc88acd

kishiguro added 3 commits August 1, 2023 19:25

Fix golangci-lint error.

37070a5

Merge branch 'react-18' of github.com:kishiguro/webconsole into react-18

99828d8

Remove diff to avoid confusion.

389ed71

brianchennn mentioned this pull request Aug 2, 2023

[Bugs?] why does this even happen webconsole [404 page not found] free5gc/free5gc#473

Closed

Handle non first DNN's FlowRules.

bcaf2fa

brianchennn mentioned this pull request Aug 3, 2023

Refactor frontend, relates to issue #35 #43

Closed

Add number of subscribers for bulk creation of the user.

1ff7846

Start from 1.

d9ce446

Set default S-NSSAI with 2 S-NSSAI configuration.

8bac6d9

kishiguro added 4 commits August 7, 2023 07:46

Fix Tenant Id -> Tenant Name.

61075c9

Refactor again -> confirm.

909d016

Support Password Confirm feature when creating new user.

25b3c96

Support password confirmation in editing the user.

290a7e1

tim-ywliu approved these changes Aug 11, 2023

View reviewed changes

tim-ywliu merged commit ba7476d into free5gc:main Aug 11, 2023
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

webconsole refactoring with react 18 #47

webconsole refactoring with react 18 #47

kishiguro commented Jul 30, 2023

brianchennn commented Jul 31, 2023

ianchen0119 Aug 1, 2023

kishiguro Aug 1, 2023

kishiguro Aug 2, 2023

brianchennn commented Aug 1, 2023 •

edited

kishiguro commented Aug 1, 2023

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023

kishiguro commented Aug 1, 2023

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023

kishiguro commented Aug 1, 2023

kishiguro commented Aug 1, 2023

kishiguro commented Aug 1, 2023

brianchennn commented Aug 2, 2023

kishiguro commented Aug 2, 2023 •

edited

brianchennn commented Aug 3, 2023 •

edited

kishiguro commented Aug 3, 2023

kishiguro commented Aug 3, 2023

brianchennn commented Aug 4, 2023 •

edited

kishiguro commented Aug 4, 2023

brianchennn commented Aug 5, 2023 •

edited

kishiguro commented Aug 5, 2023

kishiguro commented Aug 7, 2023

brianchennn commented Aug 8, 2023

		@@ -0,0 +1,234 @@
		diff --color -rc webconsole-orig/backend/WebUI/api_webui.go webconsole/backend/WebUI/api_webui.go

webconsole refactoring with react 18 #47

webconsole refactoring with react 18 #47

Conversation

kishiguro commented Jul 30, 2023

brianchennn commented Jul 31, 2023

ianchen0119 Aug 1, 2023

Choose a reason for hiding this comment

kishiguro Aug 1, 2023

Choose a reason for hiding this comment

kishiguro Aug 2, 2023

Choose a reason for hiding this comment

brianchennn commented Aug 1, 2023 • edited

kishiguro commented Aug 1, 2023

brianchennn commented Aug 1, 2023 • edited

brianchennn commented Aug 1, 2023

kishiguro commented Aug 1, 2023

brianchennn commented Aug 1, 2023 • edited

brianchennn commented Aug 1, 2023 • edited

brianchennn commented Aug 1, 2023

kishiguro commented Aug 1, 2023

kishiguro commented Aug 1, 2023

kishiguro commented Aug 1, 2023

brianchennn commented Aug 2, 2023

kishiguro commented Aug 2, 2023 • edited

brianchennn commented Aug 3, 2023 • edited

kishiguro commented Aug 3, 2023

kishiguro commented Aug 3, 2023

brianchennn commented Aug 4, 2023 • edited

kishiguro commented Aug 4, 2023

brianchennn commented Aug 5, 2023 • edited

kishiguro commented Aug 5, 2023

kishiguro commented Aug 7, 2023

brianchennn commented Aug 8, 2023

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023 •

edited

brianchennn commented Aug 1, 2023 •

edited

kishiguro commented Aug 2, 2023 •

edited

brianchennn commented Aug 3, 2023 •

edited

brianchennn commented Aug 4, 2023 •

edited

brianchennn commented Aug 5, 2023 •

edited