Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: MSISDN -> GPSI #65

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Fix: MSISDN -> GPSI #65

merged 4 commits into from
Dec 1, 2023

Conversation

brianchennn
Copy link
Contributor

Modification

MongoDB

  • collection name: subscriptionData.msisdnSupiMap 改為 subscriptionData.identityData
  • 原本 gpsi 的欄位是 msisdn: "0998774634"，我將欄位名稱改為 gpsi 並且字串內多了 prefix "msisdn-"

image

  • collection subscriptionData.ProvisionedData.amData 內部也會存 gpsis 的資料，這邊寫入的地方我也有做修改，否則會存成 "msisdn-msisdn-..."。

image

Frontend

Create Subscriber，將原本的 MSISDN 提示改為 GPSI (MSISDN)。

  • 目前前端只支援 MSISDN 格式，其他格式後端無法處理 (例如 external identifier: username@realm, TS 23.003)
  • 前端只能填入一個 GPSI (MSISDN)，但一個 SUPI 可以搭配多個 GPSIs。
    image
    View Subscriber:
    image

@tim-ywliu tim-ywliu merged commit 6108c35 into free5gc:main Dec 1, 2023
2 checks passed
@andy89923 andy89923 mentioned this pull request Dec 27, 2023
Merged
andy89923 pushed a commit to andy89923/free5gc-webconsole that referenced this pull request Jan 3, 2024
@brianchennn @andy89923
Fix: MSISDN -> GPSI (free5gc#65)
693de8c 
* fix: msisdn -> identityData

* change some function name to GPSI style

* SubsListIE.Msisdn -> SubsListIE.Gpsi

* continue to fix the gpsi format bug in api_webui.go
andy89923 pushed a commit to andy89923/free5gc-webconsole that referenced this pull request Jan 3, 2024
@brianchennn @andy89923
Fix: MSISDN -> GPSI (free5gc#65)
19c459c 
* fix: msisdn -> identityData

* change some function name to GPSI style

* SubsListIE.Msisdn -> SubsListIE.Gpsi

* continue to fix the gpsi format bug in api_webui.go
tim-ywliu added a commit that referenced this pull request Mar 3, 2024
@brianchennn @dependabot
@tim-ywliu @kishiguro @andy89923
Charging (#58)
d13a12a 
* add charging rules & billing domain

* setup billing server by config

* fix: waiting group usage for billing server

* update pdu charging data filter

* frontend: add UE CHARGING RECORD

* finish SubscriberCreate & SubscriberUpdate

* finish Charging Config in SubscriberRead.tsx

* fix: DELETE and PUT policyData.ues.chargingData when editing Subscriber's data

* fix: CheckAuth in GetChargingRecord()

* fix golangci-linter & reduce frontend vulnerabilities

* remove useless code & log in api_webui.go

* config/TLS -> cert

* fix webuicfg.yaml

* Enable to add multiple flow rules in 1 DNN

* remove SubscriberUpdate.tsx and integrate it into SubscriberCreate.tsx

* change all qfi to QosRef

* fix React Component's id naming style

* When Offline Charging, disable Quota input box

* update UI

* change default IP Filter

* update UI

* fix: when offline, quota != 0

* refactor

* implement per S-NSSAI charging config

* use frontend/build instead of ./public

* add per flow UE Charging Record

* fix: 2 flow rules use same charging config

* add expand icon

* update readme.md

* add PerFlowTableView as a React Component

* fix: undefined object use map()

* fix: the conflict of replicate IP Filter

* when delete a subscriber, remove it's CDR file

* fix: per slice charging config disappered when edit subscriber data

* fix: dnn, filter should not omit empty

* update util's hash

* fix: per slice Charging Config display error

* fix: backend pdu level quota wasn't sent to frontend

* fix: when no Charging record && sort charging record by Filter

* fix: duplicated SMF Information in REALTIME STATUS

* remove cdr file by path

* add snssai, dnn to FlowInfo & RatingGroupDataUsage

* redesign backend: GetChargingRecord()

* frontend: implemented multi snssai expand table for UE Charging Record Page

* remove redundant log

* sort flow level charging record

* Bump github.com/gin-gonic/gin from 1.9.0 to 1.9.1 (#42)

Bumps [github.com/gin-gonic/gin](https://github.com/gin-gonic/gin) from 1.9.0 to 1.9.1.
- [Release notes](https://github.com/gin-gonic/gin/releases)
- [Changelog](https://github.com/gin-gonic/gin/blob/master/CHANGELOG.md)
- [Commits](gin-gonic/gin@v1.9.0...v1.9.1)

---
updated-dependencies:
- dependency-name: github.com/gin-gonic/gin
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tim-ywliu <68043973+tim-ywliu@users.noreply.github.com>

* Query to NRF for NFProfile instead of getting from mongodb. (#63)

* Fix: MSISDN -> GPSI (#65)

* fix: msisdn -> identityData

* change some function name to GPSI style

* SubsListIE.Msisdn -> SubsListIE.Gpsi

* continue to fix the gpsi format bug in api_webui.go

* Bump @adobe/css-tools from 4.3.1 to 4.3.2 in /frontend (#67)

Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#68)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix: rebase and fix linter error

* add singleNssais sd:112233

* Refactor: refactor WebUI and fix bugs

* Feature: support offline charging

* Fix: remove unused code

* UI Modify and fix bugs

* Change default values and enhance UX

* PDU Level to silce level

* Remove comment code and add error handling

* Add postman collection

* Frontend code improvement and cleaner

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: roy19991013 <80-ChienAn@users.noreply.gitlab.nems.cs.nctu.edu.tw>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tim-ywliu <68043973+tim-ywliu@users.noreply.github.com>
Co-authored-by: Kunihiro Ishiguro <kunihiro@zebra.dev>
Co-authored-by: CTFang@WireLab <ctfang.cs12@nycu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianchen0119 ianchen0119 ianchen0119 approved these changes

@tim-ywliu tim-ywliu tim-ywliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianchennn @ianchen0119 @tim-ywliu