Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS related Dependencies and Config #77

Merged
merged 2 commits into from Mar 7, 2024

Conversation

yccodr
Copy link
Contributor

@yccodr yccodr commented Mar 6, 2024

What has been done?

  • Remove AWS related Dependencies
  • Remove AWS Cognito related components and code
  • Remove AWS related config
  • (Minor) Upgrade TS build target to ES2022

Copy link
Contributor

@andy89923 andy89923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "es5",
"target": "ES2022",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ES13 fully supported in most browsers?

Copy link
Contributor

@andy89923 andy89923 Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the ECMAScript 2023 spec is very new, there is already good support for these new array methods. Chrome 110, Safari 16.3,...

From here.

  • safari 16.3 was published in Nov 2023.
  • chrome 110 was published in Feb 2023.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are talking about IE...
but it's dead. RIP 😉

@tim-ywliu tim-ywliu merged commit 3c7fdc4 into free5gc:main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants