Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

Added missing variables #49

Closed
wants to merge 6 commits into from

Conversation

M0nica
Copy link
Contributor

@M0nica M0nica commented Jun 15, 2016

Some of the variables in the survey-data-dictionary.md were missing, so I added them in. The variable section for each question (Variable) is still the column name in the cleaned up dataset. I am only trying to commit 0789b4f. Please ignore other commits.

@M0nica
Copy link
Contributor Author

M0nica commented Jun 15, 2016

I am only trying to merge: commit 0789b4f

0789b4f

@SamAI-Software
Copy link
Member

SamAI-Software commented Jun 16, 2016

@M0nica 🆒 thanks for adding variables with 0789b4f!

A few small bugs:

  • School Major = SchoolMajor
  • Second CountryLive = CityPopulation

For visualizations you can also check out issues #40 & #41 and add them there.

@M0nica
Copy link
Contributor Author

M0nica commented Jun 16, 2016

Thanks @SamAI-Software I incorporated those two changes here: in this commit: M0nica@0e27972

@QuincyLarson
Copy link
Contributor

Hi @M0nica we are eager to merge your changes. However, there are conflicts and it seems a lot of other changes have polluted your pull request. If all of your changes are to a single file, could you:

  • copy that file's changes
  • pull the master branch
  • create a new branch off of it
  • create a new commit (paste your updated code into master's version of the file
  • create a new pull request with just that change?

Thanks for your patience and your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants