Skip to content
This repository has been archived by the owner on Jun 23, 2020. It is now read-only.

[WIP] Add maps for location, gender, ethnicity and age #54

Merged
merged 16 commits into from
Jul 15, 2016

Conversation

krisgesling
Copy link
Contributor

No description provided.

@SamAI-Software
Copy link
Member

SamAI-Software commented Jul 11, 2016

Website preview is here

  • Fix maps flicking
    • Render all maps on page load and hide them
    • Load world-geo3-min.json only one time for all maps
  • Fix the height for big screens
  • Find better color palette
    • Revert tabs colors for consistency
    • Bottom section set background-color to transparent (should be white)
    • Change "water" color to transparent (should be white)
  • Find a better position for map description
  • Fix mobile version
    • Legend
    • Padding/margin
    • Tool tip position
  • Fix scrolling (when scroll a page and hover a map, it starts zooming in/out)
    • Add +/- buttons for zooming like here
    • Disable zooming with a mouse on mobile devices
    • Find any other solution, especially for mobile devices
  • Increase readability for Gender, Ethnicity, Age with colors
    • Set minimum group size to 20 to be colored on the map
    • Add small note to the legend, that on the map colored countries with at least 20 responses.
    • Change percentage groups according to new "leaders"
    • Edit color palette for Ethnicity and Age
  • Increase readability for age
    • Reorder pie charts for consistency
    • Find a way to avoid repeating aged
  • Make a user research about section all, because it has weird logic
  • QC

@krisgesling
Copy link
Contributor Author

I've fixed the excessive file loading and the flickering has stopped even thought I haven't put any transitions in, so looks like the DOM is quick enough.
Have changed the colors, not quite to your suggestion but see what you think.
Tweaked the sizing further and added an additional breakpoint. Let me know if it's still too big on your screen.
Changed the tooltip descriptions for age but it doesn't look that great, so I'll keep thinking about different wording.
Changed the 'All' map to be called 'Location' and changed the descriptive text to make it clearer for the user. Does that help with the weird logic?

@SamAI-Software
Copy link
Member

SamAI-Software commented Jul 11, 2016

<- back to checklist

@krisgesling looks great and I like tabs colors! And yes, it fits my screen now. Also after my PR the navbar will be even smaller, so all good 👍

Changed the 'All' map to be called 'Location' and changed the descriptive text to make it clearer for the user. Does that help with the weird logic?

Yes, it's better, but as I said, user research will be the best decision. We can just ask campers about it, when it's done.

Also we can change the "water" color to transparent, and put the color legend inside the map.

Map 1

map1

Map 2

map2

Map 3

map3

Map 4

map4

I like map 1 & 3, but others also good.

@SamAI-Software
Copy link
Member

SamAI-Software commented Jul 11, 2016

<- back to checklist

Btw, we need to work a bit more on mobile version. Don't worry abt nav, it's already fixed in my PR.

image

If we set "water" color to transparent, the problem with Location tab should be fixed by itself.

And you can probably make map wider. Definitely left side 10px, may be right, too.

image

@krisgesling
Copy link
Contributor Author

krisgesling commented Jul 12, 2016

Changes made:

  • Changed water color
  • Removed margin for screens under 900px
  • Moved legend to sit on map in line with bottom right corner.
  • Rezise legend on smaller screens.
  • Moved description below legend
  • Turned off the default pie sorting in D3
  • Added minimum response size of 20 and new groupings based on the change. Also changed the final legend to be 26+% instead of 26-100% as it seemed like it was suggesting some country was in the 50+ higher range.

In regard to scroll zoom this is currently what allows mobile users to pinch zoom. Also on mobile devices while scrolling down the page a similar thing happens when you try swiping on the map you move the map instead of scrolling the page. So I can replace them with arrows and +/- buttons but it will be very slow navigating the map particularly on a mobile device.

@SamAI-Software
Copy link
Member

SamAI-Software commented Jul 12, 2016

<- back to checklist

Great! Looks awesome on all my screens! 👍

A few small issues:

Groups

Change percentage groups according to new "leaders"

image

Probably for ethnicity map we can separate Canada(27%), USA (31%) and Nepal (30%) from South Africa (63%), Thailand (52%), Malaysia (58%), South Korea (54%), etc.

E.g. 0-10%, 11-15%, 16-20%, 21%-35%, 36+%


Colors

Also colors are very similar at ethnicity and gender maps, which makes it hard to read. (Especially last 2 colors)

image

image

Good example is Age map, because it goes from very light color to very dark one, so it's very easy to spot the differences between countries, and that's exactly the reason to make a country breakdown.

image

@SamAI-Software
Copy link
Member

SamAI-Software commented Jul 12, 2016

<- back to checklist

Better make it right side & smaller & italic & opacity same like at the bar charts v2.1

image

image

@QuincyLarson QuincyLarson merged commit e5ced7f into freeCodeCamp:master Jul 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants