-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localized Versions #41
Comments
Git branch to spike on: https://github.com/freeCodeCamp/LearnToCodeRPG/tree/localization
Ex.1
Before translation# game/script.rpy:92 <-- lock this line, it's a Python comment
translate traditional_chinese start_after_interview_941d689f: <-- lock this line
# "[player_name]? What a coincidence! Our VIP team member {a=[vip_profile_url]}[player_name]{/a} will be honored to hear that." <-- lock this line, it's a Python comment
"[player_name]? What a coincidence! Our VIP team member {a=[vip_profile_url]}[player_name]{/a} will be honored to hear that." <--- this is the line that needs to be translated. see translation below After translation# game/script.rpy:92
translate traditional_chinese start_after_interview_941d689f:
# "[player_name]? What a coincidence! Our VIP team member {a=[vip_profile_url]}[player_name]{/a} will be honored to hear that."
"[player_name]?好巧,我们的VIP队友{a=[vip_profile_url]}[player_name]{/a}会很高兴的。" The Ex.2
Before translation # game/screens.rpy:261 <-- lock this line, it's a Python comment
old "{icon=icon-fast-forward} Skip" <-- lock this line, it's the original text
new "{icon=icon-fast-forward} Skip" <-- translate this line, see below After translation # game/screens.rpy:261
old "{icon=icon-fast-forward} Skip"
new "{icon=icon-fast-forward} 跳过" Again, the |
# game/script.rpy:14
translate simplified_chinese start_1b5d8b8d:
# "Hi there. Thanks for applying to our software engineering role!"
"" So looking at the localisation branch, the files are pre-populated with empty strings. Can they be prepopulated with the English text instead? Otherwise this creates issues with Crowdin's translation memory. |
Yes - we would need that done ahead of time before we push files to Crowdin. |
@nhcarrigan @raisedadead Let me know if you'd like me to add anything else. Thanks! |
@nhcarrigan Hi Nick. Thanks for the hard work and sorry for the repeated ping 😅 I saw some issues with the Crowdin translation: Some strings that should be translated aren't marked as so (important), and some strings that aren't translatable are marked as translatable (not too important).
See |
Hey @RuolinZheng08, I'll take a look at this over the weekend and see if I can get the issue resolved. For now, to maintain our goal of translating this before the Chinese new year, I'm thinking we should go ahead and make the crowdin project public to allow people to start translating the other files. What do you think? |
Just dropping screenshots of Crowdin so I can refer to those in other PRs Line to be translated: player @ surprised "{b}Full-stack{/b}... What is that? I better take notes so I can learn more about it." Crowdin chopped it into three parts: # original
player @ surprised "{b}Full-stack{/b}
# translated, keeping the opening quotes `"`
player @ surprised "{b}全栈{/b} # original
What is that?
# translated, no quotes on either side
这是什么? # original
I better take notes so I can learn more about it."
# translated, keeping the closing quotes `"`
我最好做笔记,这样我可以学习更多东西。" |
Hey its been a while since the last activity and was wondering if the translation effort was abandoned? |
What feature would you like to suggest?
We would want to deploy localized versions of the app in major world languages. Similar to the setup we have for our core learning platform.
Additional Information
We can track the needs & user stories here in this thread;
The text was updated successfully, but these errors were encountered: