Skip to content
This repository has been archived by the owner on Oct 20, 2018. It is now read-only.

Fix Breaking Build #89

Merged
merged 2 commits into from
May 7, 2016
Merged

Fix Breaking Build #89

merged 2 commits into from
May 7, 2016

Conversation

ltegman
Copy link
Member

@ltegman ltegman commented May 2, 2016

Fixes issue with missing config.json breaking travis as well as updating our lint config, fixing lint issues, and fixing a broken test.

@BerkeleyTrue BerkeleyTrue added the QA label May 2, 2016
abhisekp
abhisekp reviewed May 2, 2016
View reviewed changes
test/Bonfires.spec.js
@@ -91,14 +91,14 @@ test('Bonfires test', t => {
st.end();
});

t.test('should find raw wiki hints from KBase', st =>{
t.test('should find raw wiki hints from KBase', st => {
st.plan(1);
Copy link
Member

@abhisekp abhisekp May 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all plans
just end is fine and better. 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not within the scope of this change and not needed.

@abhisekp
Copy link
Member

abhisekp commented May 2, 2016 •
edited
Loading

@ltegman i get an "caught" error while using about command.

Testing in https://gitter.im/GitterBotX/playground

@ltegman
Copy link
Member Author

ltegman commented May 2, 2016

Could you post the full error you're seeing?

@abhisekp
Copy link
Member

abhisekp commented May 2, 2016

@ltegman

GBot>  in| about @abhisekp 
    at IncomingMessage.response.on.err (/media/Xtras/GitRepos/camperbot/lib/utils/HttpWrap.js:40:17)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:926:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
    at IncomingMessage.response.on.err (/media/Xtras/GitRepos/camperbot/lib/utils/HttpWrap.js:41:17)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:926:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
    at thanksCommands.showInfoCallback (/media/Xtras/GitRepos/camperbot/lib/bot/cmds/thanks.js:114:13)
    at IncomingMessage.response.on.err (/media/Xtras/GitRepos/camperbot/lib/utils/HttpWrap.js:44:9)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:926:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

@ltegman
Copy link
Member Author

ltegman commented May 3, 2016

@abhisekp I looked into this and I think it's just an issue with the apiServer value in the example config being missing the leading www. I've added a commit to fix this. Let me know if making that change in your config fixes the issue for you.

@abhisekp
Copy link
Member

abhisekp commented May 3, 2016

@ltegman yep! That fixed it. 👍

@raisedadead raisedadead merged commit 55bda79 into freeCodeCamp:master May 7, 2016
@BerkeleyTrue BerkeleyTrue removed the QA label May 7, 2016
@raisedadead
Copy link
Member

Thanks for the PR @ltegman I cant seem to invoke the bot, messed up my config somehow. @abhisekp has tested it locally.

I went through the changes and they look solid to me.

@Pr0methean Pr0methean mentioned this pull request Aug 22, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ltegman @abhisekp @raisedadead @BerkeleyTrue