Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Indent sample code in lesson description #16

Closed
Bouncey opened this issue Jun 15, 2018 · 5 comments
Closed

Indent sample code in lesson description #16

Bouncey opened this issue Jun 15, 2018 · 5 comments

Comments

@Bouncey
Copy link
Member

Bouncey commented Jun 15, 2018

@thefifthisa commented on Wed Jun 13 2018

Describe your problem and - if possible - how to reproduce it

Minor thing, but I think it would improve readability if the sample code below was properly indented like in other lesson descriptions.

Add a Link to the page with the problem

https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/es6/prevent-object-mutation

If possible, add a screenshot here

es6_prevent object mutation


@Nirajn2311 commented on Wed Jun 13 2018

I’ll see what I can do about it.


@Nirajn2311 commented on Fri Jun 15 2018

There is a mistake in this challenge's code of FCC's curriculum node_module

@Nirajn2311
Copy link
Member

Nirajn2311 commented Jun 15, 2018

After two days of digging I found the root of the problem and it is in package.json in learn repo.
When you do yarn install it downloads @freecodecamp/curriculum 1.0.4 version, as it is set as required version in the json file, which has some typos so the package.json in learn repo should be updated.

@moT01
Copy link
Member

moT01 commented Jun 16, 2018

I made a pr on the main repo to fix all the formatting in the seed files - there was at least several dozen challenges that needed formatting in the description - @Bouncey can you or someone else clear things up for me about the seed files? should we be making issues and PRs involving them over here now? If so, should we move all the issues over here

@Nirajn2311
Copy link
Member

Nirajn2311 commented Jun 16, 2018

@Bouncey @moT01 I have doubt whether the changes in the seed files will reflect in learn repo. Also the learn repo depends on the curriculum module. So then shouldn’t the changes be made in the curriculum module.

@moT01
Copy link
Member

moT01 commented Jun 16, 2018

I suppose since learn is now getting the challenges from this repo I should assume that changes over on the main repo wont show up - if that's the case we should maybe merge the pr's involving seed files over on the main repo and move the files over here - and maybe delete them from over there to avoid confusion - not sure where we want issues to be made - maybe we should close the over there and move them over here as well

@Nirajn2311
Copy link
Member

That’s the doubt many of us have(as I and @anku255 discussed in Gitter), if any main contributors commented on it then some of us could help in the transferring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants