Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): typos in some basic node and express challenges #115

Conversation

gforce2k5
Copy link
Contributor

fixed a typo in serve static assets challenge and in chain middleware to create a time server

ISSUES CLOSED: #113, #114

Description

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #113, #114

fixed a typo in serve static assets challenge and in chain middleware to create a time server

ISSUES CLOSED: freeCodeCamp#113, freeCodeCamp#114
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 93277e5 into freeCodeCamp:dev Jul 9, 2018
@scissorsneedfoodtoo
Copy link
Contributor

Everything LGTM 👍

Thank you for this fix, @gforce2k5.

@mpmaan
Copy link
Contributor

mpmaan commented Jul 9, 2018

@scissorsneedfoodtoo #114 is still open.....is there any reason for that? When I hover over Closes, it shows that this PR only closes #113.
It seems that @gforce2k5 should have written "Closes #113, Closes #114".

@johnkennedy9147
Copy link
Contributor

thanks @mpmaan - closed #114

@scissorsneedfoodtoo
Copy link
Contributor

Thank you for reporting that @mpmaan. I'll keep my eye out for that in the future! And thank you for closing the issue @johnkennedy9147.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in description : Basic Node and Express - Serve Static Assets
4 participants