Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(scripts): fix unpack and repack scripts for the new challenge schema #127

Merged

Conversation

ValeraS
Copy link
Contributor

@ValeraS ValeraS commented Jul 10, 2018

Description

All fields aren't in the schema will be deleted during repacking. (for example 'hints').
All fields in unpacked HTML will be added in packed JSON.

Formats for Translations and Files have been added in unpacked HTML.

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #42

Copy link

@Flarp Flarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@scissorsneedfoodtoo
Copy link
Contributor

Sorry for the delay in reviewing this, @ValeraS. Also, thank you @Flarp for helping to QA this.

Everything LGTM! Just going to wait for @raisedadead to sign off on this, too.

As I wrote in #106, since you used that as a jumping off point, I'm thinking we can merge that first, then this PR. Just waiting for the go-ahead.

@Flarp
Copy link

Flarp commented Jul 19, 2018

i only write the most high quality reviews

@raisedadead raisedadead added the status: ready for QA To be applied to PR that are ready for QA. label Jul 27, 2018
@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 52ed7cf into freeCodeCamp:dev Jul 30, 2018
@scissorsneedfoodtoo
Copy link
Contributor

@ValeraS, sorry for the delay and thank you for your patience. Everything LGTM, too! Thank you for your contribution, and we're looking forward to the next 👍

@ValeraS ValeraS deleted the fix/pack-unpack-challenges branch August 6, 2018 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: ready for QA To be applied to PR that are ready for QA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running unpack and then repack removes translations from challenge json files
4 participants