This repository has been archived by the owner on Sep 25, 2019. It is now read-only.
fix(challenges): allow for omitted unit after zero values #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshalling, thank you for reporting this issue and submitting a PR to fix it. This would be a welcome change! I think I found one typo, though. Could you take a look and possibly update your PR? |
| @@ -2237,7 +2237,7 @@ | |||
| { | |||
| "text": "The color stop at 0 pixels should be <code>yellow</code>.", | |||
| "testString": | |||
| "assert(code.match(/yellow\\s+?0px/gi), 'The color stop at 0 pixels should be <code>yellow</code>.');" | |||
| "assert(code.match(/yellow\\s+?0(px)?Z/gi), 'The color stop at 0 pixels should be <code>yellow</code>.');" | |||
There was a problem hiding this comment.
I believe this line should be:
"assert(code.match(/yellow\\s+?0(px)?/gi), 'The color stop at 0 pixels should be <code>yellow</code>.');"
|
I'm out of town right now, but I will take care of this when I get back. |
|
No problem! Please take your time. |
raisedadead
added
the
status: ready for QA
joshalling
force-pushed
the
fix/regex-omit-unit-after-zero
branch
from
91a5858
to
e6f422a
Compare
|
@scissorsneedfoodtoo I just amended my commit with that fix. |
|
@joshalling, thank you for all of your hard work to improve this challenge. Just tested and everything LGTM! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the regex of a couple Applied Visual Design challenges that do not allow the user to omit the unit after a zero value.
ISSUES CLOSED: #166