Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

fix(challenges): fixed RegEx for template literals javascript challenge #90

Conversation

gforce2k5
Copy link
Contributor

ISSUES CLOSED: #65

Description

Pre-Submission Checklist

  • Your pull request targets the dev branch.
  • Branch starts with either fix/, feature/, or translate/ (e.g. fix/challenge-tests)
  • All new and existing tests pass the command npm test.
  • Use npm run commit to generate a conventional commit message.
    Learn more here: https://conventionalcommits.org/#why-use-conventional-commits
  • The changes were done locally on your machine and NOT GitHub web interface.
    If they were done on the web interface you have ensured that you are creating conventional commit messages.

Checklist:

  • Tested changes locally.
  • Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #65

@gforce2k5
Copy link
Contributor Author

@scissorsneedfoodtoo I made a little mess in the last PR, so i opened this one instead

@scissorsneedfoodtoo scissorsneedfoodtoo merged commit 66d8463 into freeCodeCamp:dev Jun 30, 2018
@scissorsneedfoodtoo
Copy link
Contributor

@gforce2k5, no worries! Thank you for making those changes so quickly and for opening another PR. Everything LGTM 👍

@raisedadead
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex to test for Template Literals is incorrect
3 participants