You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A number of the files aren't properly formatted to the Prettier specifications. As mentioned in a previous PR, it will be wise to get around to it.
There's two different approaches we can take here. Either we do all of them at once, or we do it on a per project basis. And maybe see about adding a lint npm script.
Pros of full conversion in a single PR:
All done in one fell swoop, and we won't realistically need to do it again
Cons:
A lot of files to look at (200+)
Take some time to look at
The text was updated successfully, but these errors were encountered:
I think we can fix them all at once by running eslint . --fix and prettier --write .. Usually we do prefer reviewing smaller PRs, but this kind of change can be an exception.
We can also defer this until #484 has been completed. With pre-commit code formatting being added to the repo, PRs that address #484 would contain formatting changes as well, which helps reduce a bit the amount of files we need to deal with.
A number of the files aren't properly formatted to the Prettier specifications. As mentioned in a previous PR, it will be wise to get around to it.
There's two different approaches we can take here. Either we do all of them at once, or we do it on a per project basis. And maybe see about adding a lint npm script.
Pros of full conversion in a single PR:
Cons:
The text was updated successfully, but these errors were encountered: