Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format all the project files #528

Closed
a2937 opened this issue Nov 18, 2023 · 1 comment · Fixed by #553
Closed

Format all the project files #528

a2937 opened this issue Nov 18, 2023 · 1 comment · Fixed by #553
Labels
help wanted Extra attention is needed

Comments

@a2937
Copy link
Member

a2937 commented Nov 18, 2023

A number of the files aren't properly formatted to the Prettier specifications. As mentioned in a previous PR, it will be wise to get around to it.

There's two different approaches we can take here. Either we do all of them at once, or we do it on a per project basis. And maybe see about adding a lint npm script.

Pros of full conversion in a single PR:

  • All done in one fell swoop, and we won't realistically need to do it again

Cons:

  • A lot of files to look at (200+)
  • Take some time to look at
@huyenltnguyen
Copy link
Member

I think we can fix them all at once by running eslint . --fix and prettier --write .. Usually we do prefer reviewing smaller PRs, but this kind of change can be an exception.

We can also defer this until #484 has been completed. With pre-commit code formatting being added to the repo, PRs that address #484 would contain formatting changes as well, which helps reduce a bit the amount of files we need to deal with.

@huyenltnguyen huyenltnguyen added the help wanted Extra attention is needed label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants