Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't require pry by default" #1322

Merged
merged 1 commit into from
Nov 15, 2020
Merged

Revert "Don't require pry by default" #1322

merged 1 commit into from
Nov 15, 2020

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Nov 15, 2020

Reverts #1273

Caused the build to fail – Forwardable is provided by pry.

cc: @cmrd-senyacmrd-senya

$ bundle exec rake assets:precompile
Docs -- BEGIN
rake aborted!
NameError: uninitialized constant Docs::FilterStack::Forwardable
/home/simon/src/devdocs/lib/docs/core/filter_stack.rb:3:in `<class:FilterStack>'
/home/simon/src/devdocs/lib/docs/core/filter_stack.rb:2:in `<module:Docs>'
/home/simon/src/devdocs/lib/docs/core/filter_stack.rb:1:in `<top (required)>'
/home/simon/src/devdocs/lib/docs/core/scraper.rb:41:in `require'
/home/simon/src/devdocs/lib/docs/core/scraper.rb:41:in `<class:Scraper>'
/home/simon/src/devdocs/lib/docs/core/scraper.rb:4:in `<module:Docs>'
/home/simon/src/devdocs/lib/docs/core/scraper.rb:3:in `<top (required)>'
/home/simon/src/devdocs/lib/docs/core/scrapers/url_scraper.rb:2:in `require'
/home/simon/src/devdocs/lib/docs/core/scrapers/url_scraper.rb:2:in `<module:Docs>'
/home/simon/src/devdocs/lib/docs/core/scrapers/url_scraper.rb:1:in `<top (required)>'
/home/simon/src/devdocs/lib/docs/scrapers/github.rb:2:in `require'
/home/simon/src/devdocs/lib/docs/scrapers/github.rb:2:in `<module:Docs>'
/home/simon/src/devdocs/lib/docs/scrapers/github.rb:1:in `<top (required)>'
/home/simon/src/devdocs/lib/docs.rb:37:in `require'
/home/simon/src/devdocs/lib/docs.rb:37:in `const_get'
/home/simon/src/devdocs/lib/docs.rb:37:in `block in all'
/home/simon/src/devdocs/lib/docs.rb:37:in `map'
/home/simon/src/devdocs/lib/docs.rb:37:in `all'
/home/simon/src/devdocs/lib/docs.rb:43:in `all_versions'
/home/simon/src/devdocs/lib/tasks/docs.thor:236:in `prepare_deploy'
/home/simon/src/devdocs/Rakefile:18:in `block (2 levels) in <top (required)>'
/home/simon/src/devdocs/vendor/bundle/ruby/2.7.0/gems/rake-13.0.0/exe/rake:27:in `<top (required)>'
/usr/bin/bundle:23:in `load'
/usr/bin/bundle:23:in `<main>'

@simon04 simon04 requested a review from a team as a code owner November 15, 2020 20:44
@simon04 simon04 self-assigned this Nov 15, 2020
@simon04 simon04 merged commit f4d0c79 into master Nov 15, 2020
@simon04 simon04 deleted the revert-1273-patch-2 branch November 15, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant