Add Godot v3.4 and v3.5 #1853
Merged
Add Godot v3.4 and v3.5 #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v2 is included as one of the versions, I separated it into new files.
jessevanherk
added a commit
to jessevanherk/devdocs
that referenced
this pull request
Apr 22, 2024
This adds an encode method into the javascript code so that users can browser the Godot docs for @globalscope and @GDscript. The bug was mentioned in: freeCodeCamp#1853 This adds the encoding on the frontend, rather than trying to override filename generation in scrapers. It's possible that this will impact other documentation sources, but I expect those would also need to have encoded the @ as %40 in their own docs. This doesn't use JS' encodeURI or encodeURIComponent because encodeURI doesn't include @, and encodeURIComponent includes / which we don't want. If there are other URL-reserved characters that would be useful to encode, those should be easy enough to add to the short method added here.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at updating Godot docs. My Ruby-fu is weak so feel free to point out parts where it could be better.
Also pages that start with
@(e.g.,@GDScript,@GlobalScope) are missing and cannot be accessed. I haven't figured that out yet.If you're updating existing documentation to its latest version, please ensure that you have:
about_tmpl.coffeematches its data inself.attributionSOURCEfile inpublic/icons/your_scraper_name/are up-to-date if the documentation has a custom iconself.linkscontains up-to-date urls ifself.linksis defined