Update GitHub Action based CI workflow #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojeytonwilliams
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update GitHub Action based CI workflow, primarily to support Ruby 3.3.0 (#2110) but also for the general long term health of the project/repo. This PR does the following.
ubuntu-20.04toubuntu-latestwhich is 22.04 LTS (runs-on docs)2.7.0to4.1.1(4.1.1 release notes)1.157.0to1.165.1(1.165.1 release notes)The last one should fix CI for Ruby 3.3.0 which is currently failing due to only having access to up to
3.3.0-preview2, likely due to the version of ruby/setup-ruby.Note, usually I don't lock versions so we very well could use
actions/checkout@4andruby/setup-rubyjust like so but such could unexpectedly break at some point so I went with a more conservative approach akin to what was already in place.