Docker Image Refresh #2270
Open
Docker Image Refresh #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Legner <Simon.Legner@gmail.com>
Co-authored-by: Simon Legner <Simon.Legner@gmail.com>
…eat/docker-dev
|
Also, aside from this PR, I would be interested in becoming a maintainer for this repo. |
…p server if docs origin and app host are the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines the multiple
Dockerfile's in the repo into a single, multi-stageDockerfilethat can be used to build both development and production Docker images.I've also added a
devcontainer.jsonfile that can be used with VS Code to provider a containerized development environment. This PR was originally based off of this PR: #1337Instead of the Docker image including all the documentation by default, now users are able to select which documentation sections they want to include in their local deployment of DevDocs.
This makes it easier/faster to publish new official Docker images of DevDocs because the image size is much smaller.
All downloaded documentation and compiled assets are stored in Docker volumes instead of being baked into the image.
This also means that new Docker images only need uploaded when code changes, and not when documentation updates.
Finally, this PR adds environment variables that can be used to configure the SSL and origin settings of DevDocs when deployed via Docker container. This helps if deploying DevDocs behind a reverse proxy/load balancer, and when running on Windows via WSL2.
This PR should close:
Once this PR is merged, I would think a new Docker image should be released again, which would close #895 and this PR.