New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control+Enter keyboard shortcut should unlock the "Code locked. Unlock?" button and show a toast #16250
Comments
That's too big for a toast message, and most certainly is going to break on all screens. |
@raisedadead OK how about we assume that if they know the shortcut, they've previously run that warning, and we just run the code. No toast. |
May be a simpler way is to just update the button label from And the tooltip is already identifying the warning. So, yup we could be safe without a toast. 😅 ! |
@raisedadead I'm not a fan of tooltips, as they don't even work on touch screens. I agree that instead we should change the copy. Perhaps something like: "Code locked. Only run code you trust. Unlock? (Ctrl + Enter)" That will make it a multi-line button, but I still think it's better and more clear. |
Yes.. it seems logical to me. |
Is the work here to simply trigger a mouse click on the unlock button when the user presses Control + Enter?? |
@theoutlander I suspect there would be a more elegant way than simulating a mouse click on a button. I think you'd want to find how the control+enter logic currently works and make that trigger the unlocking of the code in the same way. |
I'm working on this one |
@theoutlander Awesome! Thanks for keeping us posted on your progress :) |
Scrolling to the bottom of lesson to unlock the code is tedious.
For power users who use the control+enter shortcut to run their code, the first time they press the control+enter shortcut, it should:
The text was updated successfully, but these errors were encountered: