Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] UI Polishing tasks which need to be done before shipping. #16293

Closed
5 tasks
vkWeb opened this issue Dec 23, 2017 · 4 comments
Closed
5 tasks

[Beta] UI Polishing tasks which need to be done before shipping. #16293

vkWeb opened this issue Dec 23, 2017 · 4 comments

Comments

@vkWeb
Copy link
Member

vkWeb commented Dec 23, 2017

[Beta] UI Polishing tasks

  • Navigation bar should look exactly similar to the master FCC.
  • The map section should be implemented like the master FCC one.
  • There should be proper margins in the lesson section for better readability.
  • On closing the map section, the lesson section isn't resizable.
  • The map button's hover animation overlaps the search bar.

Issue Description along with relevant Screenshots

1. Navigation bar should look exactly similar to the master FCC

The navigation bar looks too thin and the fonts are too small which makes it look weird especially on large screens. The implementation of the navigation bar in beta should be exactly similar to the master FCC one.

2. The map section should be implemented like the master FCC one

I really like the way map section is implemented in the master FCC (check the GIF below). It doesn't come on your way and it's easily accessible. So, I think in the beta version too we should implement the same before we ship it to the world.

3. There should be proper margins on the lesson section for better readability

There is almost no left margin in the lesson section which affects the readability on the large screens. Though, It's not properly visible in the GIF below. You can experience it much better on your machine.

4. On closing the map section, the lesson section isn't resizable

As you can see in the GIF below when the map section is not closed the lesson section gets resized easily. But when it is toggled-off the lesson section is not resizing to the left.

5. The map button's hover animation overlaps the search bar

The hover animation of map button overlaps the ending of the search bar.

Browser Information

  • Browser Name, Version: Chrome (latest release) & Firefox (57.0.2).
  • Operating System: Windows 10 Pro 32 bit.
  • Mobile, Desktop, or Tablet: Desktop.

@QuincyLarson , @systimotic , @Bouncey
These are the changes I think should be made to the beta version before shipping. You can comment your opinions down below on these :)

@Bouncey
Copy link
Member

Bouncey commented Dec 23, 2017

I agree that 3, 4 and 5 should be addressed.

@vkWeb
Copy link
Member Author

vkWeb commented Dec 23, 2017

@Bouncey I think we should put this issue in the beta-release project. What do you think?

@QuincyLarson , @systimotic , @no-stack-dub-sack . Your opinions on this, please?

@QuincyLarson
Copy link
Contributor

@vkWeb Thanks for your detailed feedback. I agree with @Bouncey that issues 3, 4, and 5 should be addressed. We made conscious decisions to overhaul the navbar and map functionality, so those will be different from how they are on production.

Could you open separate issues for your points 3, 4, and 5? That will make it easier for us to track progress on them.

@vkWeb
Copy link
Member Author

vkWeb commented Dec 23, 2017

@QuincyLarson Sure. Here are the three separate issues: #16299, #16300, #16301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants