Bad email address in authentication form should display validation errors

[QuincyLarson]

On the /signin page, if I enter an invalid email address like "test@test" it will crash the app.

[raisedadead]

Its actually not crashing the app, and the backend is throwing the error correctly.

fcc:middlewares:error-reporter Email is not a valid email address. +5s
{ Error: Email is not a valid email address.
...
...
{ type: 'errors',
     message: 'Email is not a valid email address.',
     redirectTo: '/email-signup',
     status: 400 } }

I think this needs, investigation to check why the error message isn't displayed as a flash message.

[jacobpiec]

What if you were to give the input part of it the type of "email". Doesn't HTML5 come with a way to ensure that the input is a valid email?

[raisedadead]

I think its already the case.

[jacobpiec]

So then wouldn't that be enough of an alert? Or am I missing something

[raisedadead]

Yes, the issue is its not triggered for some reason. Here is view if you are interested in debugging
https://github.com/freeCodeCamp/freeCodeCamp/blob/staging/server/views/account/email-signin.jade

Reach out to Contributors Chat room for any assistance in contributing.

Thanks.

[raisedadead]

Hi @Radlerz1 thanks for reporting. Yes indeed.

Just to clarify for future reference:

1. The native HTML validation is fine, turns out I completely missed the fact the test@test is actually a valid email just like test@localhost
2. We were not getting the server side validation messages, for a reasons unknown to me. But this has now been resolved in some recent changes merged within the last day.

Closing.