Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to switch off real-time code editor linting in the settings #16973

Closed
QuincyLarson opened this issue Mar 28, 2018 · 2 comments
Closed
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@QuincyLarson
Copy link
Contributor

CodeMirror has linting errors that pop up when you type invalid code:

basic_javascript__comment_your_javascript_code___freecodecamp

A camper suggested we allow for them to toggle these off. Is this a feature we can easily support, and if so, should we support it?

@QuincyLarson QuincyLarson added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. beta labels Mar 28, 2018
@raisedadead
Copy link
Member

@QuincyLarson we have debated over this in the past. And I believe we should not.

Reasons in short:

  1. Support requests:
    "My code is correct, but its not working"! - Usual suspects, "You missed a comma there, or that brace there, etc."

  2. Habit building as debated in asi: suppress 'missing semicolon' warning in editor  #16509
    Its easy to fall into a practice of OKAY practices for example as popularized by https://standardjs.com/#standardjs--the-rules

    That's a good thing, but the tradeoff for our audience is not justified IMHO, who are more often than just getting started to coding.

I would rather propose to have a lesson, following which you fall into a practice of typing code where you never see a warning.

Ex:

Step 1:
function ()

Step 2:
function () {}

Step 3:
function (paramA, ParamB) {
}

Step 4:
function (paramA, ParamB) {
 ...
}

And so on. I just typed that snippet out of muscle memory. I don't think I would be getting errors, in any steps.

Where this one would give me nightmares;

Ex:

Step 1:
function (

Step 2:
function (paramA, ParamB

Step 3:
function (paramA, ParamB) 

Step 4:
function (paramA, ParamB) {
 ...

So, its worth reinforcing this paradigm.

Adding a setting will make things only more complex, and we will keep getting issues that aren't worth the time for the sake convenience these offer.

BUT, that said all I am taking about is our own editor. Users should of course do whatever they wish in their own setups, for projects, local editors etc.

@QuincyLarson
Copy link
Contributor Author

@raisedadead Thanks for your detailed feedback. I hadn't thought about the spike in support issues and help questions on the forum that removing linting would cause, but you're right. This is not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

2 participants