Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass challenge, font-size of 5px, where minimum could be 6px(chrome). #17838

Closed
ghost opened this issue Jul 7, 2018 · 3 comments
Closed

Sass challenge, font-size of 5px, where minimum could be 6px(chrome). #17838

ghost opened this issue Jul 7, 2018 · 3 comments
Assignees
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.

Comments

@ghost
Copy link

ghost commented Jul 7, 2018

Describe your problem and - if possible - how to reproduce it

Challenge needs specify CSS rules, that starts from 5px as font-size. Google chrome coems with minimum 6px for now(V67), user may not pass this test.

FF has no limit for minimum font-size, but it seems test just refresh the result page once before the test begins. So it's possible test goes before any other stuffs do things(like SASS), it's a threading race issue I think.

Suggestion: instead of 5px as start font-size, this could be 10px, or better using em unit over pixel. or better adding padding/margin instead of font-size.

Add a Link to the page with the problem

https://learn.freecodecamp.org/front-end-libraries/sass/apply-a-style-until-a-condition-is-met-with-while/

https://forum.freecodecamp.org/t/apply-a-style-until-a-condition-is-met-with-while-test-case-failure/206947

Tell us about your browser and operating system

  • Browser Name: Chrome
  • Browser Version: 67
  • Operating System: Win7

If possible, add a screenshot here

@panik-stricken
Copy link

Yes. Please alter the requirements for this challenge. The forums suggest using a browser with more font flexibility, and as an aspiring developer I really should be testing my code on multiple platforms to ensure quality... which leads me to ask why as professional developers would this product alienate such a broad spectrum of users?

https://learn.freecodecamp.org/front-end-libraries/sass/apply-a-style-until-a-condition-is-met-with-while

@thecodingaviator
Copy link
Contributor

This has been fixed in the new curriculum . Please close the issue @9064911

@RandellDawson RandellDawson self-assigned this Feb 21, 2019
@RandellDawson RandellDawson added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Feb 21, 2019
@moT01
Copy link
Member

moT01 commented May 6, 2019

Fixed in beta as mentioned, the new minimum size is 15px - so this can be closed

@moT01 moT01 closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

No branches or pull requests

4 participants