Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking "Reply" in Camper News, when logged out, should bring up the login page. #259

Closed
CodeNonprofit opened this issue Mar 23, 2015 · 7 comments
Milestone

Comments

@CodeNonprofit
Copy link

Right now clicking "reply" does nothing while not logged in.

@CodeNonprofit CodeNonprofit added this to the News milestone Mar 23, 2015
@BerkeleyTrue
Copy link
Contributor

Thanks @CodeNonprofit. Any campers out their want to tackle this?

@BerkeleyTrue
Copy link
Contributor

Will also add upvote button to this ticket.

@terakilobyte
Copy link
Contributor

What should it do? A popover?

@BerkeleyTrue
Copy link
Contributor

Unauthenticated campers clicking on reply or upvote should be redirected to login page. Once logged in they should be redirected back to the page they were on before.

@ghost
Copy link

ghost commented Mar 28, 2015

Is this worth fixing since you guys are moving away from this branch?

@terakilobyte
Copy link
Contributor

It is worth fixing, we're keeping the ux-improvements feature branch patched with the latest changes from master and camper news lives separate from 99% of the changes we're making

@ghost
Copy link

ghost commented Mar 28, 2015

#271

Also while fixing this, the Story user = ; JS error is back. I think the previous fix caused login problems? That's the reasoning for using typeof in the updated code since just doing !user would cause an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants