Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS/JS minification infrastructure #361

Closed
QuincyLarson opened this issue Apr 24, 2015 · 4 comments
Closed

Remove CSS/JS minification infrastructure #361

QuincyLarson opened this issue Apr 24, 2015 · 4 comments
Assignees

Comments

@QuincyLarson
Copy link
Contributor

This crashed last night, and makes our js and css unreadable in the browser. It's not worth it for the marginal performance gains.

@QuincyLarson
Copy link
Contributor Author

Hey @BerkeleyTrue, since you started removing this can you finish removing it? We all agree that this is an unnecessary complication.

@BerkeleyTrue
Copy link
Contributor

Alrighty. I WIll get in the next couple of days.

@QuincyLarson
Copy link
Contributor Author

@BerkeleyTrue While you're fixing our static assets and removing connectAssets, could you help us decide whether we need all 3 of these:

app.use(
  express.static(path.join(__dirname, 'public'), {maxAge: 31557600000})
);
// todo
// why are there two express.static declarations?
app.use(express.static(__dirname + '/public', { maxAge: 86400000 }));
var oneYear = 31557600000;
// todo
// another app.use(express.static...) call
app.use(express.static(__dirname + '/public', {maxAge: oneYear}));

@QuincyLarson
Copy link
Contributor Author

@BerkeleyTrue Actually, I'm making a ton of progress on this. So why don't you stay focused on React and I'll take this. Bower is amazing!

@QuincyLarson QuincyLarson added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed todo labels May 4, 2015
@QuincyLarson QuincyLarson removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants