Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitpod documentation and update config for remote #36572

Closed
raisedadead opened this issue Aug 7, 2019 · 5 comments
Closed

Add gitpod documentation and update config for remote #36572

raisedadead opened this issue Aug 7, 2019 · 5 comments
Labels
help wanted Open for all. You do not need permission to work on these. scope: docs Codebase and other documentation scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: resolved/shipping To be applied to issues or PR's that are already fixed and are awaiting DevOps deployment

Comments

@raisedadead
Copy link
Member

We need the ability to be able to launch the GitPod workspaces with the origin remote NOT pointing to the main repository, but the fork of the user instead.

If the later is not possible, then at least removing the remote, so that the user notices the remote missing while pushing.

Additional guidelines around this are also required to be documented for setting remotes in the terminal within GitPod.

Finally the best place to document this would be to move the same from the Contributing Guide and place it in the how to work on freeCodeCamp locally guide.

Some references:
https://github.com/freeCodeCamp/freeCodeCamp/blob/master/.gitpod.yml#L15
https://www.gitpod.io/docs/44_config_start_tasks

@raisedadead raisedadead added the help wanted Open for all. You do not need permission to work on these. label Aug 7, 2019
@raisedadead
Copy link
Member Author

raisedadead commented Aug 7, 2019

/cc @cmccormack for looking over my earlier oversight.

@raisedadead raisedadead added scope: docs Codebase and other documentation scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. labels Aug 7, 2019
@leodaher
Copy link
Contributor

If the user launches GitPod from their fork, the origin remote points to the fork, doesn't it?

@raisedadead
Copy link
Member Author

raisedadead commented Aug 11, 2019

If the user launches GitPod from their fork, the origin remote points to the fork, doesn't it?

It does. We are looking to solve the edge case where maintainers on this repository have write access to the upstream (this repo), and the forget about the push rights when working on a instance that the launched from the main repo.

Its possible that they will accidentally push changes upstream instead of their fork.

@leodaher
Copy link
Contributor

Oh, I get it now! Can I work on a PR for this issue?

I'm guessing we could assume the user has a fork, and try to set the remote origin to it (git does not return an error if the url does not exist).

@raisedadead
Copy link
Member Author

Yup. Thanks for working on this.

@raisedadead raisedadead added the status: resolved/shipping To be applied to issues or PR's that are already fixed and are awaiting DevOps deployment label Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: docs Codebase and other documentation scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: resolved/shipping To be applied to issues or PR's that are already fixed and are awaiting DevOps deployment
Projects
None yet
Development

No branches or pull requests

2 participants