Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"for" attributes on labels in "Build a Survey Form" #37961

Closed
nellarro opened this issue Dec 19, 2019 · 4 comments
Closed

"for" attributes on labels in "Build a Survey Form" #37961

nellarro opened this issue Dec 19, 2019 · 4 comments
Labels
other: decayed Stale issues that need follow up from commentators. Were closed for inactivity scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have

Comments

@nellarro
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No. It is related to a little added accessibility to the "Build A Survey Form" requirements.

Describe the solution you'd like
Adding "for" attributes to labels so that a student's eventual form is a smidge more accessible

Describe alternatives you've considered
Adding placeholder text.

@nellarro nellarro added the type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have label Dec 19, 2019
@raisedadead raisedadead added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Dec 23, 2019
@alti21
Copy link

alti21 commented Feb 27, 2020

Hi can I work on this?

@RandellDawson
Copy link
Member

@alti21 To resolve this issue involves more than just adding a new user story description. You would also need to update the user story in the testable-projects-fcc repo and update the applicable tests associated with the challenge.

@AshNaz87
Copy link
Contributor

@RandellDawson Submitted a PR

Next steps?

@moT01
Copy link
Member

moT01 commented Apr 23, 2021

Sorry it's been so long on this one everyone.

I'm not sure we want to add more tests to this project. It's been pretty static for quite some time. Adding tests will break a lot of previously submitted projects. I don't mind the extra tests, it's probably good practice to use the for attribute. I could go either way, but I think we might just want to leave it alone.

@raisedadead raisedadead added the other: decayed Stale issues that need follow up from commentators. Were closed for inactivity label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other: decayed Stale issues that need follow up from commentators. Were closed for inactivity scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have
Projects
None yet
6 participants