Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(learn): python certification projects #38271

Merged
merged 41 commits into from May 27, 2020
Merged

feat(learn): python certification projects #38271

merged 41 commits into from May 27, 2020

Conversation

raisedadead
Copy link
Member

@raisedadead raisedadead commented Feb 26, 2020 •
edited

Final PR to land the projects on staging instance

To be landed via FAST forward.

@gitpod-io
Copy link

gitpod-io bot commented Feb 26, 2020 •
edited

@raisedadead
Copy link
Member Author

raisedadead commented Feb 26, 2020 •
edited

🚨 The below PRs should be resolved before landing this:

raisedadead
raisedadead commented Feb 26, 2020
View reviewed changes
Copy link
Member Author

@raisedadead raisedadead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some comments, while work on cleaning this PR of forum ids. @freeCodeCamp/dev-team please feel free to push changes here too.

api-server/common/models/user.json Show resolved Hide resolved
client/src/templates/Challenges/projects/ProjectForm.js Outdated Show resolved Hide resolved
tools/scripts/seed/seedAuthUser.js Outdated Show resolved Hide resolved
@scissorsneedfoodtoo
Copy link
Contributor

@raisedadead, I think I was able to get the certificates working. I went ahead and used the naming scheme listed above, and removed the forumIds while I was at it. But I didn't get a chance to look at projectForm.js yet.

What's the best way to push my changes here? Should I open another PR and point it to next-python-projects?

@raisedadead
Copy link
Member Author

What's the best way to push my changes here? Should I open another PR and point it to next-python-projects?

You should push to the next-python-projects branch on upstream, which will update this PR.

@beaucarnes
Copy link
Member

I implemented the suggestion of @ojeytonwilliams and created the placeholder text in Show.js to pass in to ProjectForm.js. That ended up leading me down a long path where I added an extra challenge type. Previously, the new Python challenges were set as type backEndProject. Now they are type pythonProject. Adding a new type involved updating quite a bit of files including creating an all-new Show.js just for the pythonProject type.

@beaucarnes
Copy link
Member

Just saw that one of the test failed. In this instance, the test needs to be updated.
ValidationError: child "challengeType" fails because ["challengeType" must be less than or equal to 9]
I added a challengeType of 10. And there could be more challengeTypes in the future as we add video challenges.

I'm not sure how to update a test.

@ojeytonwilliams
Copy link
Contributor

If the only difference between the backend Show.js and python Show.js is the placeholder, we could just modify backend/Show.js to change the placeholder if it has challengeType === pythonProject. That would cut out a lot of repetition.

I've tried it locally and it seems fine, so I can clean that up and push a commit if that helps.

@beaucarnes
Copy link
Member

@ojeytonwilliams You are probably right that a new Show.js in not needed for Python. Sure, it would be great if you could push a commit with the code you have that just uses backend/Show.js.

@ojeytonwilliams
Copy link
Contributor

@beaucarnes done! I hope that helps.

@beaucarnes
Copy link
Member

@ojeytonwilliams This looks great, thanks!

@camperbot camperbot added language: English scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. labels Feb 29, 2020
@raisedadead raisedadead marked this pull request as ready for review March 2, 2020 05:23
@raisedadead raisedadead requested a review from a team March 2, 2020 05:23
@RandellDawson RandellDawson added the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Mar 2, 2020
@raisedadead raisedadead removed the status: merge conflict To be applied to PR's that have a merge conflict and need updating label Mar 2, 2020
@raisedadead raisedadead force-pushed the next-python-projects branch 3 times, most recently from 0d8444f to 15856cd Compare March 6, 2020 06:58
@RandellDawson
Copy link
Member

RandellDawson commented Mar 7, 2020 •
edited

@raisedadead @beaucarnes There are 155 JavaScript curriculum files on this PR. These changes should be removed to make it easier to review. I can provide a list of the 155 files if you need them.

@RandellDawson RandellDawson added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Mar 7, 2020
@raisedadead
Copy link
Member Author

Hi @RandellDawson I will be reseting this PR, soon. Beau and myself were testing some stuff and hence the noise. Please ignore this PR for the minute.

@raisedadead raisedadead force-pushed the next-python-projects branch 3 times, most recently from b59e701 to a83aabf Compare March 9, 2020 17:19
raisedadead and others added 25 commits May 27, 2020 13:19
@raisedadead
fix(client): nicer error message and layout update
286ba76
@moT01 @raisedadead
feat: add loader on video challenges (#38633)
ef79ddd
@rayswebpresence @raisedadead
Data Analysis Example A, Shape Property of DataFrames (#38654)
ded962e
@beaucarnes @raisedadead
feat(learn): add Numpy video question. (#38619)
b101d4b
@beaucarnes @raisedadead
Feat: add python security video course (#38683)
3a65343
@niraliG @raisedadead
feat(learn): add jupyter Notebook Cells video Question (#38628)
04412cb
@ojeytonwilliams @raisedadead
feat: process video question md into html (#38667)
de0bec8 
* feat: process video question md into html

* test: mdToHTML

* fix: use dedicated prism component
@erictleung @raisedadead
fix: Jupyter notebook challenge file name (#38740)
4dd985f
@rayswebpresence @ojeytonwilliams
@erictleung @beaucarnes @raisedadead
Importing CSV Using Pandas Module (#38721)
3a91d88 
* Importing CSV Using Pandas Module

* feat: process video question md into html (#38667)

* feat: process video question md into html

* test: mdToHTML

* fix: use dedicated prism component

* fix: Jupyter notebook challenge file name (#38740)

* fix quote error

Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
Co-authored-by: Beau Carnes <beaucarnes@gmail.com>
@rayswebpresence @raisedadead
Data Cleaning Duplicates: Duplicated Method (#38719)
9901cc4
@rayswebpresence @raisedadead
Read Data Fr Databases: Methods Available to a Cursor (#38720)
2dd9798
@rayswebpresence @raisedadead
feat(learn): Pandas Extracting Tables from HTML (#38726)
c30fd2a
@rayswebpresence @erictleung @raisedadead
feat(learn): NumPy Algebra and Size: Size and Efficiency (#38725)
add7feb 
* NumPy Algebra and Size: Size and Efficiency Question

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/numpy-algebra-and-size.english.md

Co-authored-by: Eric Leung <eric@erictleung.com>

Co-authored-by: Eric Leung <eric@erictleung.com>
@rayswebpresence @raisedadead
feat(learn): Denoting Code Blocks in Python (#38723)
1284406
@rayswebpresence @raisedadead
feat(learn): Data Analysis Example B - Using the 'Loc' Method (#38656)
1cb664c
@rayswebpresence @beaucarnes
@erictleung @raisedadead
Data Cleaning/Viz- Subplot Method Arguments (#38655)
35ede1f 
* Data Cleaning/Viz- Subplot Method Arguments

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/data-cleaning-and-visualizations.english.md

Co-authored-by: Eric Leung <eric@erictleung.com>

* Update curriculum/challenges/english/08-data-analysis-with-python/data-analysis-with-python-course/data-cleaning-and-visualizations.english.md

Co-authored-by: Eric Leung <eric@erictleung.com>

* fix yaml

Co-authored-by: Beau Carnes <beaucarnes@gmail.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
@rayswebpresence @beaucarnes
@erictleung @raisedadead
Dictionary Iteration: Printing Key, Value Pairs (#38722)
e21439d 
* Dictionary Iteration: Printing Key, Value Pairs

* Apply suggestions from code review

Co-authored-by: Eric Leung <eric@erictleung.com>

Co-authored-by: Beau Carnes <beaucarnes@gmail.com>
Co-authored-by: Eric Leung <eric@erictleung.com>
@raisedadead
fix(learn): update project views for python
9879d6e
@raisedadead
fix: move around new CIP challenges
8248d70 
Move newly added rosetta code challenges
@raisedadead
chore: update challengeType 11 to hidden
82a9296
@raisedadead
chore: update challengeType 10 to hidden
cdabd90
@raisedadead
chore: update python, IS and QA cert challenge 7 to hidden
1fe1789
@raisedadead
chore: update new IS, QA challenge 4 to hidden
74430b3
@moT01 @ojeytonwilliams @raisedadead
fix: allow ctrl+enter to submit video lessons (#38898)
911ba72 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@moT01 @ojeytonwilliams @raisedadead
fix: backend projects not submitting (#38900)
db08ab2 
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
@github-pages github-pages bot temporarily deployed to github-pages May 27, 2020 08:03 Inactive
@raisedadead raisedadead merged commit db08ab2 into master May 27, 2020
@raisedadead
Copy link
Member Author

Hi @moT01 can you please create issues for the outstanding things in your QA run. We can take them up now.

@raisedadead raisedadead deleted the next-python-projects branch May 27, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaucarnes beaucarnes beaucarnes left review comments

@scissorsneedfoodtoo scissorsneedfoodtoo scissorsneedfoodtoo left review comments

@ojeytonwilliams ojeytonwilliams ojeytonwilliams approved these changes

Assignees
No one assigned
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@raisedadead @scissorsneedfoodtoo @beaucarnes @ojeytonwilliams @RandellDawson @moT01 @camperbot @rayswebpresence @niraliG @erictleung