Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylistic change: Waypoint: Use jQuery to Modify the Entire Page #3896

Closed
ParkinT opened this issue Oct 25, 2015 · 5 comments
Closed

Stylistic change: Waypoint: Use jQuery to Modify the Entire Page #3896

ParkinT opened this issue Oct 25, 2015 · 5 comments

Comments

@ParkinT
Copy link

ParkinT commented Oct 25, 2015

In this particular lesson there is a sudden (and unexplained) switch from double-quotes to single-quotes in all the JQuery parameters.
This will, likely, be confusing to students and - although I suspect it was simply a mistake - it should be explained that either is acceptable.

@anrddh
Copy link
Member

anrddh commented Oct 28, 2015

Thanks for reporting the issue @ParkinT, but the waypoint uses double quotes (see attached screenshot)?

Nevertheless, I'll open a PR with a note in the waypoint ASAP. Thanks :)
screenshot 1

@ParkinT
Copy link
Author

ParkinT commented Oct 28, 2015

@awesomeaniruddh That screenshot illustrates my point.
Perhaps you misunderstood.

I am referring to the examples in the instructions.
Up to this point they were consistent and used double-quotes. At this Waypoint the 'sample' in the instructions uses single-quotes.

@anrddh
Copy link
Member

anrddh commented Oct 28, 2015

Ah, I just noticed. Thanks for letting me know.

@anrddh anrddh self-assigned this Oct 28, 2015
@bugron
Copy link
Contributor

bugron commented Nov 19, 2015

@awesomeaniruddh what's your progress on this?

@bugron bugron added help wanted Open for all. You do not need permission to work on these. and removed in progress labels Dec 3, 2015
@erictleung
Copy link
Member

It looks like the single quotes in the instructions were changed to double quotes already. Maybe we should close this?

image

@texas2010 texas2010 removed the help wanted Open for all. You do not need permission to work on these. label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants