-
-
Notifications
You must be signed in to change notification settings - Fork 35.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass challenge timeout #39432
Comments
Hey Oliver, When I clicked on the link, I reset the code, and completed the challenge as it should be completed. I came across a However, after resetting the code, refreshing the page, and pasting in the code you provided (missing So, I suspect it has to do with the page first load, because I can get the
|
I tried @SKY020's method but that didn't produce the bug. I am able to reliably reproduce the bug on Chromium & Firefox with the following steps:
Note: it can also be reproduced where by in step 2 you end on re-adding the It must have something to do with the console state change and the output error check conflicting. |
I worked on this issue on my old computer that is very slow and on my main PC (with a dual boot). On my old computer I have the same result as @ojeytonwilliams, regurlaly timeouts. On the new one to have this issue I have to paste 3 times the piece of code to reproduce it. But everytimes, this is a real timeout (5ms, I put 'new Date()' on the code). We can upgrade the source code one "execute-challenge-saga.js" with this kind of stuff to have a best message, but still the problem : let errMsg = 'error'; if (err === 'timeout') { // eslint-disable-next-line no-ex-assign errMsg = `The code you have written is taking longer than the ${previewTimeout}ms our challenges allow. You may have created an infinite loop or need to write a more efficient algorithm`; } else if (Array.isArray(err) && err.length>0 && err[0] === 'timeout') { // timeout: 5ms errMsg = `Server response timeout`; } else { errMsg = err; } console.log(errMsg); yield put(updateConsole(escape(errMsg))); so the result will be "Server response timeout" |
While this is old, it's still reproducible, unfortunately. A PR to improve the warning would be welcome. |
I’m currently taking a look into a possible solution on this! |
Describe the bug
Sass pages with invalid syntax occasionally timeout
To Reproduce
Steps to reproduce the behavior:
timeout
in the console (sometimes)Expected behavior
The following should appear in the console:
Since this is intermittent, here's a gif to demonstrate:
Additional Context
When the error appears it does so very quickly, so it is unlikely that this is due to a genuine timeout.
The text was updated successfully, but these errors were encountered: