Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation tests #39980

Open
ojeytonwilliams opened this issue Oct 15, 2020 · 7 comments
Open

Donation tests #39980

ojeytonwilliams opened this issue Oct 15, 2020 · 7 comments
Assignees
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.

Comments

@ojeytonwilliams
Copy link
Contributor

ojeytonwilliams commented Oct 15, 2020

We should have more tests for /donate and the donate form. Cypress tests, if possible, so that we can confirm that the donation flow works correctly. Since external services (PayPal and Stripe) are involved, we should find a way to stub those out.

For example:

const { error } = await stripe.redirectToCheckout({
items: [item],
successUrl: donationUrls.successUrl,
cancelUrl: donationUrls.cancelUrl
});

would need to be replaced by a stub. That way we can test everything around that (selection of different durations and amounts, what happens on success and failure and so on) without relying on the UI of an external service.

Here are the types of donations we need tests for:

  1. donation modal stripe
  2. donation modal paypal
  3. donate page stripe
  4. donate page paypal
@ojeytonwilliams ojeytonwilliams added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Oct 15, 2020
@ahmaxed
Copy link
Member

ahmaxed commented Oct 15, 2020

@Twaha-Rahman, since you have been spearheading our test coverage expansion efforts, I was wondering if you have any thoughts on this matter before we start with the implementation?

@Twaha-Rahman
Copy link
Contributor

Twaha-Rahman commented Oct 16, 2020

I don't know much about the /donation page or it's features so can't say much about it.... but able to test it with Cypress would be a big plus without a doubt.

Also maybe add the search feature to the list too. The ability to test the search feature in the navbar would be a nice addition.
(But this maybe a separate issue altogether 🤔 )

@raisedadead
Copy link
Member

It wont be trivial for a non-staff member to test these out without the Stripe setup (and PayPal etc). I recommend this to be taken up one of the Staff instead.

@ojeytonwilliams
Copy link
Contributor Author

Sure, we can handle this - we just wanted to track it somewhere and see if anyone had any input.

@ojeytonwilliams
Copy link
Contributor Author

More discussion in: #40702

@moT01
Copy link
Member

moT01 commented Jun 8, 2022

Update: @ahmadabdolsaheb is working on this.

@ahmaxed
Copy link
Member

ahmaxed commented Feb 17, 2023

#49381 Donation block popping for new responsive web design should be implemented as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc.
Projects
None yet
Development

No branches or pull requests

5 participants