assert.throws Doesn't Count Towards Assertions

[SethFalco]

Describe your problem and how to reproduce it:
I was working on the Sudoku Solver project and ran into an issue with my tests failing despite my unit tests passing locally.

Test case:

test('Invalid puzzle strings fail the solver', (done) => {
  const puzzleString = '115..2.84..63.12.7.2..5.....9..1....8.2.3674.3.7.2..9.47...8..1..16....926914.37.';
  assert.throws(() => solver.solve(puzzleString), 'Puzzle cannot be solved');
  done();
});  

Unit tests:

Network tab:

I can see in the tests for the project, it dictates all tests must have at least one assertion. I do have an assertion though, but it's not being returned.

Add a Link to the page with the problem:
https://www.freecodecamp.org/learn/quality-assurance/quality-assurance-projects/sudoku-solver

Tell us about your browser and operating system:

• Browser Name: Firefox
• Browser Version: 86.0 (64-bit)
• Operating System: Ubuntu 20.04.2 LTS x86_64

[sachinh19]

Have you tried doing something like this?

expect(() => solver.solve(puzzleString)).toThrow('Puzzle cannot be solved');

[SethFalco]

Have you tried doing something like this?

expect(() => solver.solve(puzzleString)).toThrow('Puzzle cannot be solved');

I've already passed the task so I don't need to work around it anymore.
However, I did try expect(() => solver.solve(puzzleString)).throw('Puzzle cannot be solved'); anyway.

This did not fix the issue. I'm betting it's probably something to do with the pattern not catching the () => syntax as a valid assertion, but haven't looked into it much yet.

[sachinh19]

We could probably close this issue since you have already finished the task.

[SethFalco]

I think the problem lies with how the functions looks at runtime.

// assert.isFalse -> assert.isFalse.
function (done) { var puzzleString = '1.5..2.84..63.12.7.2..5.....9..1....8.2.3674.3.7.2..9.47...8..1..16....926914.37.'; var actual = solver.checkRegionPlacement(puzzleString, 0, 1, 2); assert.isFalse(actual); done(); }

// assert.throws -> assert["throws"]
function (done) { var puzzleString = '115..2.84..63.12.7.2..5.....9..1....8.2.3674.3.7.2..9.47...8..1..16....926914.37.'; assert["throws"](function () { return solver.solve(puzzleString); }, 'Puzzle cannot be solved'); done(); }

The regex can be updated to:

const cleanedBody = body.match(/(?:browser\s*\.\s*)?assert\s*(?:\.\s*\w*|\s*\[(["'])\w*\1\])\([\s\S]*\)/);

This will allow it to also work with the ["property"] syntax as well, for example:

Other parts will also still have to be updated, but unfortunately those methods are more complex, so I will review them later.
Just wanted to share some progress on it so far.

---

The following is a hack, but a quick and dirty fix instead is to update #assertionAnalyser to do the following to body at the start:

function assertionAnalyser(body) {
  if (!body)
    return "invalid assertion";

  body = body.replace(/assert\[(["'])(\w*)\1\]/, (match, p1, p2) => {
    return `assert.${p2}`;
  });

This will change assert["throws"] back to assert.throws and allow the rest to run as is, and the test cases will pass successfully! \(^-^)/
This is probably not an ideal solution, however. It'd be better to just parse the ["property"] syntax correctly.

[SethFalco]

We could probably close this issue since you have already finished the task.

No, because this is still a valid issue. I could work around it for now, however others will still encounter it when they shouldn't, and it still needs to be fixed.

[NikIvan]

I've encountered same issue while was trying to use assert.throws() and assert.doesNotThrow() in some tests.

If adding this methods would be difficult, text of error in console should be fixed at least because now it's misleading. It says something like each test should contain at least one assert and obviously my tests contain asserts.

So maybe easy fix would be change description of this project (and maybe others which have same issue) and say something like Use at least one assert.equal in your tests to pass them

[Sboonny]

here is the file curriculum/challenges/english/06-quality-assurance/quality-assurance-projects/sudoku-solver.md

I am planning to solve the project, first. then I will attempt to solve this, because of fCC honest policy